[UoM prototype] Render measurement attributes in docs (3/3)#952
Open
ricardotejedorsanz wants to merge 1 commit into
Open
[UoM prototype] Render measurement attributes in docs (3/3)#952ricardotejedorsanz wants to merge 1 commit into
ricardotejedorsanz wants to merge 1 commit into
Conversation
c6fa39c to
77f1df6
Compare
45ff80f to
eb4dcd4
Compare
eb4dcd4 to
7c562f9
Compare
jeanguo-png
reviewed
Jul 1, 2026
jeanguo-png
left a comment
Collaborator
There was a problem hiding this comment.
Non-blocking: could we default missing attribute.type to closed_list in the shared layouts? Older release docs data does not include type, so those pages will render a blank Type value even though the attributes are effectively closed-list. A small Liquid default would keep old release pages looking correct while supporting measurement attributes in the new data.
danielpgross
approved these changes
Jul 3, 2026
danielpgross
left a comment
Collaborator
There was a problem hiding this comment.
Approach looks fine (details will depend on whether we make further changes to the data model)
|
|
||
| #### Attribute types | ||
|
|
||
| Attributes include an explicit `type`. Closed-list attributes define a set of taxonomy values. Measurement attributes define a `measurement_type` and `supported_units` instead of values. |
Collaborator
There was a problem hiding this comment.
This is pretty terse, it might help to add some examples here for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR updates the public docs/visualizer path to understand measurement attributes introduced in #950 and bulk-imported in #951.
It is stacked on #951 so the visualizer can be reviewed with the V0 measurement vocabulary.
What changed
typefor attributes.measurement_typeandsupported_unitsinstead of a values list.UX changes
The visualizer now makes the attribute type explicit when an attribute is expanded:
Type: closed_list, followed by aValueslabel and their allowed taxonomy values.Type: measurement,Measurement type, andSupported unitsinstead of a values list.Image 1 — closed-list attribute expanded in a category:
Image 2 — measurement attribute expanded in a category:
Image 3 — measurement attribute on the attribute details page:
Validation
ruby -cpassed for the changed Ruby serializers/tests.bundle exec rake test:unitpassed.bundle exec bin/product_taxonomy docspassed.bundle exec jekyll build --source ../docs --destination /tmp/product-taxonomy-docs-sitepassed.measurement_typeandsupported_units, and closed-list attributes with aValueslabel.git diff --checkpassed.