Use hash-literal in package_test over kwarg#427
Open
cosgroveb wants to merge 1 commit intoShopify:mainfrom
Open
Use hash-literal in package_test over kwarg#427cosgroveb wants to merge 1 commit intoShopify:mainfrom
cosgroveb wants to merge 1 commit intoShopify:mainfrom
Conversation
It is deprecated in Ruby 3.3 and removed in 3.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is deprecated in Ruby 3.3 and removed in 3.4.
What are you trying to accomplish?
I am building and packaging Packwerk internally for Ruby 3.4.
This will be necessary in the future for upstream and so I am
contributing this minor change back.
What approach did you choose and why?
Hash-literal
What should reviewers focus on?
N/A
Type of Change
Checklist