Remove empty_commit file, as it seems unnecessary#302
Merged
alexevanczuk merged 1 commit intomainfrom Feb 10, 2023
Merged
Conversation
alexevanczuk
approved these changes
Feb 10, 2023
Contributor
alexevanczuk
left a comment
There was a problem hiding this comment.
This was definitely added accidentally, thanks for removing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Remove an empty file in the repository's root named
empty_commit.The file was added in #276, where I could not find an explanation for its presence.
What approach did you choose and why?
git rmWhat should reviewers focus on?
My assumption is that this file was added in order to create an "empty commit" that would trigger CI.
I'd like to confirm that.
For reference, the following command creates an empty commit without the need to commit any file.
Type of Change
Additional Release Notes
Include any notes here to include in the release description. For example, if you selected "breaking change" above, leave notes on how users can transition to this version.
If no additional notes are necessary, delete this section or leave it unchanged.
Checklist