Skip to content

Refine bundle size report comments - #870

Merged
markmur merged 3 commits into
mainfrom
refine-size-report-comment
Oct 2, 2026
Merged

markmur merged 3 commits into
mainfrom
refine-size-report-comment

Conversation

@markmur

@markmur markmur commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Size reports show commit SHAs and acceptance instructions even when budgets pass. Remove the visible SHA line, show acceptance guidance only for unresolved soft or hard budget breaches, and add status emojis to the results.

Rename the heading to Bundle Size Budgets and reduce its table to four columns: Budget, Size, Limits, and Result. Combine platform and measurement labels, show the current size with its change, and put soft and hard limits together. Keep compression labels explicit and show changes smaller than 1 KiB in bytes. Base sizes remain in the detailed measurement table.

Collapse the measurement explanation under How sizes are measured. Preserve the budget rules and hidden acceptance state.

@markmur
markmur requested a review from a team as a code owner October 2, 2026 12:30
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Oct 2, 2026
@markmur markmur self-assigned this Oct 2, 2026
@markmur
markmur enabled auto-merge (squash) October 2, 2026 12:34
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

Size budgets

Measured head: e3536d1cff40ba39dd6df57b78162c43c0fcb2f6; base: 0d8f23739a4d8d4aeb4c171005c3432d8f9d5995.

Platform / budget Measurement Base Head Delta Soft Hard Result
web / javascript Bundle (uncompressed) 33.27 KiB 33.27 KiB 0.00 KiB 35 KiB 50 KiB Within budget

Repository writers, including the PR author, can accept current soft-budget breaches with a reason:

/accept-size web Explain why this increase is necessary.

Use one command per platform; several lines can share a comment. Post after this report is ready for the current head. Commands in edited comments are not accepted.

Acceptance applies to each currently exceeded metric up to its recorded size. Further growth or a newly exceeded metric needs fresh acceptance. Hard-budget increases require a reviewed change to .ci/bundle-size-budgets.json.

Bundle and package size

Web bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.

Platform Measurement Compression Base Head Delta
Web JavaScript bundle Uncompressed 33.3 KiB 33.3 KiB 0 B
Web JavaScript bundle gzip 10.2 KiB 10.2 KiB 0 B
Web npm package (.tgz) gzip 89.5 KiB 89.5 KiB 0 B
React Native npm package (.tgz) gzip 119.6 KiB 119.6 KiB 0 B
Android Library package (.aar) ZIP 407.6 KiB 407.6 KiB 0 B
Web package files (uncompressed)

These are uncompressed file sizes; they do not sum to the compressed package size above.

File Base Head Delta
dist/index.js.map 249.0 KiB 249.0 KiB 0 B
dist/index.d.ts 47.9 KiB 47.9 KiB 0 B
dist/custom-elements.json 47.5 KiB 47.5 KiB 0 B
dist/index.js 33.3 KiB 33.3 KiB 0 B
README.md 20.2 KiB 20.2 KiB 0 B
package.json 3.6 KiB 3.6 KiB 0 B
LICENSE 1.1 KiB 1.1 KiB 0 B
React Native package files (uncompressed)

These are uncompressed file sizes; they do not sum to the compressed package size above.

File Base Head Delta
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.ts 108.7 KiB 108.7 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/Models.d.ts 73.1 KiB 73.1 KiB 0 B
android/src/main/java/com/shopify/reactnative/checkoutkit/ShopifyCheckoutKitModule.java 16.2 KiB 16.2 KiB 0 B
ios/ShopifyCheckoutKit.swift 16.1 KiB 16.1 KiB 0 B
ios/AcceleratedCheckoutButtons.swift 14.1 KiB 14.1 KiB 0 B
src/components/AcceleratedCheckoutButtons.tsx 13.0 KiB 13.0 KiB 0 B
src/index.ts 12.7 KiB 12.7 KiB 0 B
lib/commonjs/index.js 12.4 KiB 12.4 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js 11.4 KiB 11.4 KiB 0 B
src/index.d.ts 11.3 KiB 11.3 KiB 0 B
lib/commonjs/components/AcceleratedCheckoutButtons.js.map 10.4 KiB 10.4 KiB 0 B
lib/module/index.js 10.4 KiB 10.4 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js 10.2 KiB 10.2 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.ts 9.5 KiB 9.5 KiB 0 B
lib/module/components/AcceleratedCheckoutButtons.js.map 9.1 KiB 9.1 KiB 0 B
lib/module/index.js.map 8.1 KiB 8.1 KiB 0 B
src/present-dispatcher.ts 8.0 KiB 8.0 KiB 0 B
lib/commonjs/index.js.map 7.9 KiB 7.9 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolRenameMap.ts 7.8 KiB 7.8 KiB 0 B
node_modules/@shopify/checkout-kit-protocol/src/generated/ProtocolNotifications.d.ts 7.6 KiB 7.6 KiB 0 B
…and 117 smaller files
Android package files (uncompressed)

These are uncompressed file sizes; they do not sum to the compressed package size above.

File Base Head Delta
classes.jar 434.3 KiB 434.3 KiB 0 B
res/layout/checkout_view_content.xml 2.6 KiB 2.6 KiB 0 B
res/layout/checkout_sheet_content.xml 2.0 KiB 2.0 KiB 0 B
res/values/values.xml 1.3 KiB 1.3 KiB 0 B
R.txt 1.2 KiB 1.2 KiB 0 B
AndroidManifest.xml 922 B 922 B 0 B
proguard.txt 798 B 798 B 0 B
res/drawable/close.xml 431 B 431 B 0 B
res/menu/checkout_menu.xml 354 B 354 B 0 B
META-INF/com/android/build/gradle/aar-metadata.properties 157 B 157 B 0 B
How sizes are measured

Measured from the PR base SHA and PR head SHA. Web bundle rows sum shipped .js, .mjs, and .cjs files under dist/, excluding source maps and declarations. The gzip bundle size sums files compressed individually with gzip -n -9. npm package sizes are gzip-compressed .tgz archives; Android AAR sizes are ZIP archives. Package sizes are not final app binary sizes.

@markmur

markmur commented Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

↑ heads up the changes will only apply when this PR lands in main

@markmur
markmur merged commit 2454ff6 into main Oct 2, 2026
27 checks passed
@markmur
markmur deleted the refine-size-report-comment branch October 2, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants