Skip to content

feat(web): report unsupported browser capabilities - #868

Open
kiftio wants to merge 2 commits into
mainfrom
web-unsupported-browser-error
Open

kiftio wants to merge 2 commits into
mainfrom
web-unsupported-browser-error

Conversation

@kiftio

@kiftio kiftio commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

What changes are you making?

  • Detect missing Shadow DOM, native dialog, and abortable event-listener support before opening checkout.
  • Emit the existing non-bubbling error event with detail.error.code === "unsupported_browser", without opening a checkout window.
  • Document the fallback pattern and cover the event behavior.

How to test

  • dev web test
  • dev web lint

Stacked on #860.

@kiftio
kiftio added this pull request to stack #869 October 2, 2026 11:27
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Oct 2, 2026
@kiftio
kiftio force-pushed the web-unsupported-browser-error branch from d23ed25 to 8a8190d Compare October 2, 2026 11:33
@kiftio
kiftio marked this pull request as ready for review October 2, 2026 11:40
@kiftio
kiftio requested a review from a team as a code owner October 2, 2026 11:40
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 96%
94.31% (398/422) 83.6% (209/250) 96.29% (104/108)

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Size budgets

Measured head: 3cf8a4293dec10a230e410accb27160499943adf; base: 0d8f23739a4d8d4aeb4c171005c3432d8f9d5995.

Platform / budget Measurement Base Head Delta Soft Hard Result
web / javascript Bundle (uncompressed) 33.27 KiB 34.06 KiB +0.78 KiB 35 KiB 50 KiB Within budget

Repository writers, including the PR author, can accept current soft-budget breaches with a reason:

/accept-size web Explain why this increase is necessary.

Use one command per platform; several lines can share a comment. Post after this report is ready for the current head. Commands in edited comments are not accepted.

Acceptance applies to each currently exceeded metric up to its recorded size. Further growth or a newly exceeded metric needs fresh acceptance. Hard-budget increases require a reviewed change to .ci/bundle-size-budgets.json.

Bundle and package size

Web bundle sizes cover shipped runtime JavaScript. Package sizes cover the full published archive, including any source maps, declarations, and documentation it contains.

Platform Measurement Compression Base Head Delta
Web JavaScript bundle Uncompressed 33.3 KiB 34.1 KiB +800 B
Web JavaScript bundle gzip 10.2 KiB 10.4 KiB +231 B
Web npm package (.tgz) gzip 89.5 KiB 91.0 KiB +1.4 KiB
Web package files (uncompressed)

These are uncompressed file sizes; they do not sum to the compressed package size above.

File Base Head Delta
dist/index.js.map 249.0 KiB 252.1 KiB +3.1 KiB
dist/custom-elements.json 47.5 KiB 48.8 KiB +1.3 KiB
dist/index.d.ts 47.9 KiB 48.0 KiB +46 B
dist/index.js 33.3 KiB 34.1 KiB +800 B
README.md 20.2 KiB 20.8 KiB +544 B
package.json 3.6 KiB 3.6 KiB 0 B
LICENSE 1.1 KiB 1.1 KiB 0 B

Measured from the PR base SHA and PR head SHA. Web bundle rows sum shipped .js, .mjs, and .cjs files under dist/, excluding source maps and declarations. The gzip bundle size sums files compressed individually with gzip -n -9. npm package sizes are gzip-compressed .tgz archives; Android AAR sizes are ZIP archives. Package sizes are not final app binary sizes.

Base automatically changed from web-browser-compatibility to main October 2, 2026 12:12
@kiftio
kiftio force-pushed the web-unsupported-browser-error branch from 8a8190d to 7b061f5 Compare October 2, 2026 12:12
@markmur
markmur force-pushed the web-unsupported-browser-error branch from 7b061f5 to 3cf8a42 Compare October 2, 2026 12:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant