Skip to content

[Web] Add checkout page objects and structured browser coverage - #866

Merged
kiftio merged 1 commit into
mainfrom
web-e2e-page-objects
Oct 2, 2026
Merged

kiftio merged 1 commit into
mainfrom
web-e2e-page-objects

Conversation

@markmur

@markmur markmur commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Browser specs currently mix checkout behavior with DOM access, popup setup, and event extraction. Introduce CheckoutHostPage and ShopifyCheckoutPopup so scenarios use named checkout actions and typed state/event reads, and separate synthetic checkout routing from the network guard.

Split the suite into presentation and protocol specs. Bring over the coverage from #418 for registration, URL handling, popup closing, change notifications, window delegation, and terminal errors, adapted to the current lifecycle API. Preserve #855's completion assertions, SDK-derived types, negotiated protocol version, network isolation, and workspace/CI setup.

Stack

@markmur
markmur requested a review from a team as a code owner October 2, 2026 10:14
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 96%
95.16% (374/393) 84.32% (199/236) 97.08% (100/103)

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Web npm tarball 89.4 KiB 89.4 KiB 0 B
Web file breakdown
File Base Head Delta
dist/index.js.map 249.1 KiB 249.1 KiB 0 B
dist/index.d.ts 47.9 KiB 47.9 KiB 0 B
dist/custom-elements.json 47.5 KiB 47.5 KiB 0 B
dist/index.js 33.3 KiB 33.3 KiB 0 B
README.md 20.1 KiB 20.1 KiB 0 B
package.json 3.2 KiB 3.2 KiB 0 B
LICENSE 1.1 KiB 1.1 KiB 0 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

@markmur
markmur added this pull request to stack #867 October 2, 2026 10:22
@markmur markmur self-assigned this Oct 2, 2026
@markmur
markmur force-pushed the web-e2e-page-objects branch from 92e8dae to 9aaa276 Compare October 2, 2026 10:23
@markmur markmur mentioned this pull request Oct 2, 2026
3 of 11 tasks
@markmur
markmur force-pushed the web-e2e-page-objects branch from 9aaa276 to f764beb Compare October 2, 2026 10:40
Base automatically changed from web-e2e-harness to main October 2, 2026 11:17
@kiftio
kiftio force-pushed the web-e2e-page-objects branch from f764beb to 24a9cb2 Compare October 2, 2026 11:17
@kiftio
kiftio merged commit 0f773aa into main Oct 2, 2026
26 checks passed
@kiftio
kiftio deleted the web-e2e-page-objects branch October 2, 2026 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants