Extract shared Web checkout presentation - #839
Open
tiagocandido wants to merge 1 commit into
Open
tiagocandido wants to merge 1 commit into
tiagocandido wants to merge 1 commit into
Conversation
tiagocandido
added this pull request to stack #845
September 28, 2026 15:20
tiagocandido
marked this pull request as ready for review
September 28, 2026 15:23
Package Size
Web file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Extract Web checkout presentation into shared presentation helpers so the standard and Universal elements can share popup, overlay, focus and close behavior. Preserve the standard element's protocol-neutral events and Kit-owned snapshot mapping.
Reset presentation state before opening, reject messages from a null or unrelated sender, and isolate queued dialog-close callbacks from a newly opened presentation. Keep appearance, popup fallback and telemetry navigation timing intact.
How to test
From the repository root, with dependencies installed:
pnpm --dir platforms/web lint pnpm --dir platforms/web test pnpm --dir platforms/web build pnpm --dir platforms/web verify pnpm --dir platforms/web sample:buildThe full stack passes 440 Web tests plus lint/typechecks, build, package verification and sample build. Regression coverage includes close/reopen, blocked popups, sender/origin isolation, presentation reset, and standard lifecycle events.