Handle undefined optional protocol fields - #838
Merged
Merged
Conversation
tiagocandido
added this pull request to stack #845
September 28, 2026 15:20
tiagocandido
marked this pull request as ready for review
September 28, 2026 15:23
Package Size
Web file breakdown
React Native file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
approved these changes
Sep 29, 2026
kiftio
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Treat optional
undefinedprotocol fields as absent, matching JSON semantics when browserpostMessageuses structured clone. Previously a checkout containingorder: undefinedcould lose its entire start/update event. Required undefined fields, nulls where disallowed by the schema, and malformed nested objects remain invalid; the decoder preserves legacy fulfillment normalization.Include the failing field path in safe decode diagnostics, keep the published TypeScript declarations aligned, and cover the shared codec through Web and React Native consumers.
How to test
From the repository root, with dependencies installed:
The full stack passes 88 protocol tests, 440 Web tests, Web lint/typechecks, package verification and sample build. The React Native protocol suite also passes all 19 tests. The structured-clone regression asserts that optional keys disappear from the delivered snapshot while invalid present orders are rejected.