Add a blocked event when the checkout window is blocked - #835
Open
kyle-schellen wants to merge 1 commit into
Open
kyle-schellen wants to merge 1 commit into
kyle-schellen wants to merge 1 commit into
Conversation
Package Size
Web file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
kyle-schellen
added this pull request to stack #837
September 28, 2026 13:15
kyle-schellen
force-pushed
the
ks-web-blocked-popup-event
branch
from
September 28, 2026 15:03
33a26ff to
684898d
Compare
kyle-schellen
force-pushed
the
ks-web-blocked-popup-event
branch
from
September 28, 2026 16:14
684898d to
b83b70d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Stacked on #791. Retarget to
mainonce it merges.When the browser blocks the checkout window, the component now dispatches a
blockedevent. With #791 alone, stores that hide the overlay get no signal at all, and no store can track how often checkout is blocked.blockedfires on every blocked attempt, including retries, whether or not the overlay is shown. It bubbles and has no detail, likeclose.open()directly from ablockedlistener is ignored with a warning. Without that guard, the call is blocked again and recurses until the browser throws "Maximum call stack size exceeded".ShopifyCheckoutBlockedEventand ablockedentry inShopifyCheckoutEventMap. The README events table and the sample app's event log include it.How to test
dev web testanddev web lint. New tests coverblockedwith the overlay shown and hidden, and the ignoredopen()call from a listener.pnpm sample): under Flow, choose Use existing checkout source and paste a cart permalink. Runwindow.open = () => nullin the DevTools console, then click Open checkout:blockedappears in the Events panel. Reload to undo.document.head.append(Object.assign(document.createElement('style'), { textContent: 'shopify-checkout::part(overlay) { display: none; }' }))before clicking Open checkout. No overlay appears, andblockedstill fires.Before you merge
Important
platforms/web/README.md)