chore: bump node to latest LTS + GitHub actions to latest - #955
Merged
Merged
Conversation
Node 18 reached end of life in April 2025. This bumps all node version references to v24.19.0 (Krypton), the current active LTS. Why dev.yml can't just read .nvmrc: the Shopify 'dev' tool requires an explicit exact version in dev.yml (the 'version' field is required and used to run 'nvm install <version>'), so we can't eliminate it and rely on .nvmrc alone. .nvmrc uses the flexible major version 'v24' (for nvm users who want the latest patch automatically) while dev.yml pins the exact v24.19.0 that the dev tool installs. To enforce sync between these two files, a new 'check-node-version' CI job validates that the major version in .nvmrc matches the one in dev.yml on every PR. This catches drift even when contributors don't run 'dev up' locally (the dev tool does its own .nvmrc↔dev.yml check during 'dev up', but that only runs when someone remembers to run it). Co-authored-by: AI (Pi/GLM 5.2 Fast (Fireworks) [1m]) <noreply@pi.dev>
kdaviduik
force-pushed
the
node-version
branch
from
August 22, 2026 03:05
0f8038e to
c284774
Compare
kdaviduik
changed the title
kdaviduik
marked this pull request as ready for review
August 22, 2026 03:18
| pull_request: | ||
|
|
||
| jobs: | ||
| check-node-version: |
There was a problem hiding this comment.
This is like the hydrogen check too right?
EvilGenius13
approved these changes
Aug 24, 2026
kdaviduik
added a commit
that referenced
this pull request
Sep 15, 2026
Replace static NPM_TOKEN authentication with OIDC token exchange for npm publishing. OIDC provides short-lived tokens derived from the GitHub Actions workflow identity, eliminating the risk of long-lived credential compromise. Key changes: - Remove NODE_AUTH_TOKEN env var (leaving it undefined triggers OIDC) - Set NPM_TOKEN to empty string (forces OIDC fallback) - Add a Test OIDC Token step that verifies the OIDC token exchange succeeds before the publish step runs - Fix package.json repository field from SSH shorthand to structured HTTPS format (required for OIDC provenance attestation) - id-token: write permission already present on main Node 24 (bundling npm 11 with native OIDC support) already landed on main via PR #955, so no node bump is needed here. Build gate: verified build + 794 tests pass on Node 24.14.0 (npm 11.9.0) Snapit OIDC migration deferred — only npm-release.yml is configured as a Trusted Publisher on npmjs.com. Snapit continues using NPM_TOKEN. Co-Authored-By: Claude <noreply@anthropic.com>
kdaviduik
added a commit
that referenced
this pull request
Sep 15, 2026
Replace static NPM_TOKEN authentication with OIDC token exchange for npm publishing. OIDC provides short-lived tokens derived from the GitHub Actions workflow identity, eliminating the risk of long-lived credential compromise. Key changes: - Remove NODE_AUTH_TOKEN env var (leaving it undefined triggers OIDC) - Set NPM_TOKEN to empty string (forces OIDC fallback) - Add a Test OIDC Token step that verifies the OIDC token exchange succeeds before the publish step runs - Fix package.json repository field from SSH shorthand to structured HTTPS format (required for OIDC provenance attestation) - id-token: write permission already present on main Node 24 (bundling npm 11 with native OIDC support) already landed on main via PR #955, so no node bump is needed here. Build gate: verified build + 794 tests pass on Node 24.14.0 (npm 11.9.0) Snapit OIDC migration deferred — only npm-release.yml is configured as a Trusted Publisher on npmjs.com. Snapit continues using NPM_TOKEN. Co-Authored-By: Claude <noreply@anthropic.com>
kdaviduik
added a commit
that referenced
this pull request
Sep 15, 2026
Replace static NPM_TOKEN authentication with OIDC token exchange for npm publishing. OIDC provides short-lived tokens derived from the GitHub Actions workflow identity, eliminating the risk of long-lived credential compromise. Key changes: - Remove NODE_AUTH_TOKEN env var (leaving it undefined triggers OIDC) - Set NPM_TOKEN to empty string (forces OIDC fallback) - Add a Test OIDC Token step that verifies the OIDC token exchange succeeds before the publish step runs - Fix package.json repository field from SSH shorthand to structured HTTPS format (required for OIDC provenance attestation) - id-token: write permission already present on main Node 24 (bundling npm 11 with native OIDC support) already landed on main via PR #955, so no node bump is needed here. Build gate: verified build + 794 tests pass on Node 24.14.0 (npm 11.9.0) Snapit OIDC migration deferred — only npm-release.yml is configured as a Trusted Publisher on npmjs.com. Snapit continues using NPM_TOKEN. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Node 18 reached end of life in April 2025. This bumps all node version references in the repo to v24.19.0 (Krypton), the current active LTS.
Pinned all GitHub Actions to their latest versions by commit SHA (supply-chain best practice, matching Hydrogen's pattern):
Also adds a new CI job (same as Hydrogen's) to ensure that the node versions in
dev.ymland.nvmrccan't go out of sync without CI screaming.Verifying the pinned SHAs
Each SHA below links to its GitHub commit page so you can confirm it matches the tagged release:
actions/checkout3d3c42e5aac5ba805825da76410c181273ba90b1actions/setup-node820762786026740c76f36085b0efc47a31fe5020pnpm/action-setup0977fd99725f1db4007ccb2928dbb4e90d06cc86Why dev.yml can't just read from .nvmrc
The Shopify dev tool requires an explicit exact version in dev.yml — the version field is required and is used to run nvm install . It can't read from .nvmrc. So we can't eliminate the version specification in dev.yml and rely on .nvmrc alone. This is why the two files exist separately and why the sync-check CI job is needed: .nvmrc uses the flexible major version v24 (for nvm) while dev.yml pins the exact v24.19.0 (for the dev tool).
The dev tool does its own .nvmrc ↔ dev.yml check during dev up, but that only runs when a contributor remembers to run it locally. The new CI job catches drift on every PR — including from external contributors who don't have the dev tool.
This mirrors the pattern already in place in Shopify/hydrogen.