Add Content-type header to Faraday request#13
Open
Andersond11 wants to merge 2 commits intomasterfrom
Open
Conversation
brasic
suggested changes
May 9, 2018
Contributor
brasic
left a comment
There was a problem hiding this comment.
Oops, think it's in the wrong place. shouldn't it be in post? GETs should not have bodies.
Contributor
|
I think I recall that our GETs do sometimes have bodies, which is odd, but at any rate, the header should also be added to |
Author
|
Yes, I fixed that in the bundled copy then put it in the wrong spot when I cloned the repo for the PR |
cdd545e to
fad9d8b
Compare
brasic
approved these changes
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that was introduced when we moved to Rack 2.0.4 where a POST request without a content-type caused Rack to attempt to url decode the body. When this happened to a body that included
%in any of it's contents, the request would blow up withArgumentError - invalid %-encoding. The following two curl commands demonstrate the issue and solution locally:This command without the content header will blow up with the above error:
Adding the
Content-type: application/jsonheader results in the appropriate order validation errors, since the payload doesn't contain complete order data: