Implement shared validators for params/state/auth - #2
Open
Shecodes174 wants to merge 3 commits into
Open
Conversation
- Create shared soroban-validation crate with reusable validation functions - Add typed ValidationError enum with categorized error codes (100-399) - Implement parameter validation: validate_amount, validate_string, validate_address, validate_array, validate_timestamp - Implement state validation: require_sufficient_balance, require_cooldown_expired, require_initialized - Implement auth validation: require_owner, require_admin, require_role, require_not_blacklisted - Update validation patterns example to use shared validators - Update authentication example to use shared validation patterns - Add shared validation pattern to common patterns documentation - Update workspace Cargo.toml to include shared crate
- Add comprehensive ValidationError enum with 309 error codes - Implement parameter validation functions (amount, string, address, array, timestamp) - Implement state validation patterns (initialized, balance, cooldown) - Implement authorization validation patterns (owner, admin, role, blacklist) - Update validation-patterns example to use shared validators - Add contracterror attribute for proper Soroban integration - Include full test coverage for validation functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements shared validators for params/state/auth as requested.
Changes
Acceptance Criteria Met