Repository navigation
Fix CompiledTrace capture for the Sendable mlx-swift compile API - #86
Merged
Merged
Conversation
mlx-swift's compile now takes an @escaping @sendable closure. The closure in CompiledTrace.compiled(_:) captured the non-Sendable owner, which Swift 6 rejects (CompiledTrace.swift:162). Keep the owner unowned in a small unchecked-Sendable box so the closure captures only Sendable values. Behavior is unchanged: the trace still holds its owner unowned and runs only against it. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlx-swift's
compilenow takes an@escaping @Sendableclosure.CompiledTrace.compiled(_:)captured the non-Sendable owner, so Swift 6 rejects it with "converting non-Sendable function value ... may introduce data races" (CompiledTrace.swift:162). This is what breaks the umbrella job on SharpAI/mlx-swift#28.The fix keeps the owner unowned, in a small
@unchecked Sendablebox, so the closure captures only Sendable values. The trace still never retains its owner and still only runs against it.Verification: the local build is blocked on this machine (missing Metal toolchain component), so CI is the check here. Downstream: after this merges, SwiftLM's mlx-swift-lm pin needs a bump before the umbrella job on mlx-swift#28 can pass.
🤖 Generated with Claude Code