feat(onvif): Allow configuring the network interface hardware address - #32
Open
nilp0inter wants to merge 1 commit into
Open
nilp0inter wants to merge 1 commit into
nilp0inter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31
Context
When running multiple
reolinkproxyinstances across separate network interfaces, each instance has a distinct IP and MAC address. However,GetNetworkInterfacespreviously returned a hardcoded hardware address (00:00:00:00:00:00), causing NVRs such as UniFi Protect to detect duplicate network interface identities during enrollment.Changes
HWAddressfield toONVIFConfigandonvifConfigdefaulting to"00:00:00:00:00:00".--onvif-hw-addressCLI flag bound to theREOLINK_ONVIF_HW_ADDRESSenvironment variable.HWAddressinGetNetworkInterfacesResponse.HwAddressincmd/reolinkproxy/onvif_test.go.REOLINK_ONVIF_HW_ADDRESSand--onvif-hw-addressinREADME.md.