Skip to content

Commit 077930b

Browse files
Docs: what the 1.0.1 window remembers, and the window checks
The changelog and release notes said ShadowCode "still remembers where the window was" under a Wayland heading, where the compositor ignores the position, and the release notes' heading said the window keeps its size, the opposite of the fix. They now say the size is no longer remembered on any desktop, that maximized and full screen are, and the place only on X11, and describe the fit as it now works (1229x691 with the title bar on 1366x768; the screen it reopens on, or every screen on Wayland). NATIVE_DESKTOP no longer says window geometry is retained. RELEASING notes that the scripts need Node 22.12 or newer and lists the X11 and private Wayland window tests for window changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent fc20601 commit 077930b

4 files changed

Lines changed: 44 additions & 17 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,21 @@
66
such as KDE Plasma, every launch opened the window about 52 px wider and
77
99 px taller, until it no longer fit on the screen. The window draws its
88
own title bar there, and the saved size included that title bar and the
9-
window's shadow, so restoring it added them again. ShadowCode still
10-
remembers where the window was and whether it was maximized or full
11-
screen, but no longer its size. A window that already grew opens at its
9+
window's shadow, so restoring it added them again. ShadowCode no longer
10+
remembers the window's size on any desktop, so it opens at its default
11+
size, fitted to the screen. It still reopens maximized or full screen if
12+
you left it that way, and on X11 at the same place; on Wayland the desktop
13+
chooses where the window opens. A window that already grew opens at its
1214
normal size again.
1315
- **The window fits small screens.** The window opened at 1380x920 even on a
1416
1366x768 screen, so the composer and status bar sat under the panel. It
15-
now opens at no more than 90% of the screen it opens on, less room for the
16-
title bar (1229x643 on a 1366x768 screen), and still at 1380x920 on larger
17-
screens. On a screen too small for the smallest window (520x640) it opens
18-
maximized. A window that was maximized when you closed it opens maximized
19-
again.
17+
now opens at no more than 90% of the screen, title bar included (1229x691
18+
on a 1366x768 screen), and still at 1380x920 on larger screens. On X11 it
19+
fits the screen it reopens on, and a window last left low on the screen
20+
moves up until it fits. On Wayland, where the desktop picks the screen, it
21+
fits every screen. It opens maximized only when no screen can hold the
22+
smallest window (520x640). A window that was maximized when you closed it
23+
opens maximized again.
2024

2125
## 1.0.0: Easy to start, ready for real work
2226

‎docs/NATIVE_DESKTOP.md‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,14 @@ Prove it with `node --test scripts/test-native-packaging-env.mjs`.
197197
HTTP/HTTPS links open through the OS; remote pages cannot replace the app view.
198198
- Default-profile launches focus the existing instance. Isolated profiles have
199199
separate webview storage and still enforce their own profile locks.
200-
- Window geometry is retained for the default profile. Desktop notifications
200+
- For the default profile the window reopens maximized or full screen if it
201+
was, and on X11 at its last place (moved up or left until it fits that
202+
screen's work area); a Wayland compositor chooses the place itself. Its
203+
size is not remembered (`window_size.rs`): it opens at 1380x920, or at 90%
204+
of a smaller screen with room for the title bar (the X11 window manager's
205+
frame, or GTK's header bar inside the size on Wayland), on the screen it
206+
reopens on (X11) or fitting every screen (Wayland). It opens maximized only
207+
when no such screen holds the 520x640 minimum. Desktop notifications
201208
cover approvals waiting (and a warning 2 minutes before a vendor approval is
202209
denied), failed tasks, plan limits and finished tasks, each switchable in
203210
Settings › Appearance with an optional sound. They appear while the window

‎docs/RELEASE_NOTES.md‎

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,20 @@ it opens on Wayland, and it fits small screens. The 1.0.0 notes follow below.
55

66
## Fixed
77

8-
- **The window keeps its size.** On Wayland desktops such as KDE Plasma, the
9-
window opened a little bigger every time (about 50 pixels wider and 100
10-
taller) until it no longer fit on the screen. ShadowCode now remembers
11-
where the window was and whether it was maximized, but not its size. If
12-
your window already grew, it opens at its normal size again.
8+
- **The window no longer grows each time it opens.** On Wayland desktops
9+
such as KDE Plasma, the window opened a little bigger every time (about 50
10+
pixels wider and 100 taller) until it no longer fit on the screen.
11+
ShadowCode no longer remembers the window's size on any desktop, so it
12+
opens at its default size, fitted to the screen. It still reopens
13+
maximized or full screen if you left it that way, and on X11 at the same
14+
place. If your window already grew, it opens at its normal size again.
1315
- **The window fits small screens.** On a 1366x768 screen the window used to
1416
be taller than the screen, so the composer and the status bar were hidden
1517
under the panel. The window now opens at a size that fits the screen, with
16-
room for the title bar and the panel. Larger screens still get the full
17-
size, a very small screen gets a maximized window, and a window you left
18+
room for the title bar and the panel. With more than one screen it fits
19+
the screen it reopens on (X11), or every screen (Wayland, where the
20+
desktop chooses). Larger screens still get the full size, the window opens
21+
maximized only when no screen is big enough for it, and a window you left
1822
maximized opens maximized.
1923

2024
## Download

‎docs/RELEASING.md‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,19 @@ node scripts/check-secrets.mjs
7676
```
7777

7878
Build the desktop executable before running the Rust suite: the process tests
79-
launch `target/debug/shadowcode`. `check-secrets.mjs` also runs in the CI
79+
launch `target/debug/shadowcode`. The scripts need Node.js 22.12 or newer,
80+
like the UI: with an older `node` first on `PATH`, `test-native-cli.mjs`
81+
stops with `ERR_UNKNOWN_BUILTIN_MODULE` (`node:sqlite`). A change to the
82+
window also needs the window test on X11 and on a private Wayland
83+
compositor (see [NATIVE_DESKTOP.md](NATIVE_DESKTOP.md); Weston 13 and
84+
WebKitWebDriver can be unpacked copies):
85+
86+
```sh
87+
node scripts/run-native-x11.mjs node scripts/test-native-desktop.mjs
88+
node scripts/run-native-wayland.mjs node scripts/test-native-desktop.mjs
89+
```
90+
91+
`check-secrets.mjs` also runs in the CI
8092
"Checks" workflow, not in `release.yml`; run it before pushing the tag.
8193
Live turns against real accounts (`live_vendor_turn`) are described under
8294
[Tests](../README.md#tests) in the README.

0 commit comments

Comments
 (0)