fix: Add guards against crashing in the plugin loader if the network isn't available and avoid null references

core/global/plugin_loader.gd

@@ -93,36 +93,56 @@ func disable_plugin(plugin_id: String) -> void:
 	SettingsManager.set_value("plugins.enabled", plugin_id, false)
 
 
-## Returns the parsed dictionary of plugin store items. Returns null if there
-## is a failure.
-func get_plugin_store_items() -> Variant:
+## Returns the parsed dictionary of plugin store items. Returns an empty
+## dictionary if there is a failure.
+func get_plugin_store_items() -> Dictionary:
 	if not parent:
 		logger.error("Plugin loader has not been initialized!")
-		return
+		return {}
 	var http: HTTPRequest = HTTPRequest.new()
 	parent.add_child.call_deferred(http)
 	await http.ready
+
+	# Bail out before touching any freed objects.
+	if not is_instance_valid(parent) or not is_instance_valid(http):
+		return {}
+
 	if http.request(PLUGIN_STORE_URL) != OK:
 		logger.error("Error making http request to plugin store")
-		parent.remove_child(http)
+		if is_instance_valid(parent) and is_instance_valid(http):
+			parent.remove_child(http)
 		http.queue_free()
-		return null
+		return {}
 
 	# Wait for the request signal to complete
 	var args: Array = await http.request_completed
+
+	# Guard against the request node having been freed while we were
+	# awaiting the response.
+	if not is_instance_valid(http):
+		return {}
+
 	var result: int = args[0]
 	var response_code: int = args[1]
 	var headers: PackedStringArray = args[2]
 	var body: PackedByteArray = args[3]
 
 	if result != HTTPRequest.RESULT_SUCCESS:
 		logger.error("Plugin store http request failed")
-		parent.remove_child(http)
+		if is_instance_valid(parent):
+			parent.remove_child(http)
 		http.queue_free()
-		return null
+		return {}
+
+	if is_instance_valid(parent):
+		parent.remove_child(http)
+	http.queue_free()
 
 	# Parse the results
-	var items: Dictionary = JSON.parse_string(body.get_string_from_utf8())
+	var items: Variant = JSON.parse_string(body.get_string_from_utf8())
+	if items == null or not items is Dictionary:
+		logger.error("Unable to parse plugin store response")
+		return {}
 
 	return items
 

core/ui/card_ui/settings/plugin_store_menu.gd

@@ -24,7 +24,12 @@ func _ready() -> void:
 # signal with the loaded items
 func load_plugin_store_items():
 	# Fetch available plugins from the plugin store
-	var plugin_items = await plugin_loader.get_plugin_store_items()
+	var plugin_items := await plugin_loader.get_plugin_store_items()
+
+	# Bail out early if the node was freed while waiting
+	if not is_instance_valid(self):
+		return
+
 	plugin_store_loaded.emit(plugin_items)
 
 
@@ -96,6 +101,9 @@ func _populate_plugin_store_item(grid: Container, plugin_id: String, plugin: Dic
 	# Load the plugin image
 	if len(plugin["store.images"]) > 0:
 		var image = await http_image.fetch(plugin["store.images"][0])
+		# Bail out before touching any freed objects to avoid a crash.
+		if not is_instance_valid(self) or not is_instance_valid(store_item):
+			return
 		if image != null:
 			store_item.plugin_texture.texture = image