Skip to content

v0.46.0: custom_maximum_size collides with Godot 4.7's native Control property, breaking the game launch menu #540

Description

@zhinu

Environment

  • OpenGamepadUI v0.46.0 (opengamepadui-bin on Arch/CachyOS), the released binary
  • Engine: 4.7.1.stable.official
  • gamescope, NVIDIA RTX 5070 Ti, niri as the outer compositor

Symptom

Every startup logs:

SCRIPT ERROR: Parse Error: Member "custom_maximum_size" redefined (original in native class 'Control')
          at: GDScript::reload (res://core/ui/components/install_location_dialog.gd:34)
SCRIPT ERROR: Parse Error: Member "custom_maximum_size" redefined (original in native class 'Control')
          at: GDScript::reload (res://core/ui/components/install_options_dialog.gd:33)
SCRIPT ERROR: Compile Error: Failed to compile depended scripts.
          at: GDScript::reload (res://core/ui/card_ui/launch/game_launch_menu.gd:0)
ERROR: Failed to load script "res://core/ui/card_ui/launch/game_launch_menu.gd" with error "Compilation failed".

game_launch_menu.gd therefore never loads, so picking a game in the library goes nowhere.

Cause

Godot 4.7 added a native Control.custom_maximum_size. core/ui/components/install_location_dialog.gd:34 and core/ui/components/install_options_dialog.gd:33 both declare @export var custom_maximum_size: Vector2i, which is now a redefinition. Both are still present on main, and the published v0.46.0 binary is built against 4.7.1, so the shipped release is affected - this is not only a source-tree problem.

Suggested fix

Rename the exported variable (and the matching property names stored in install_location_dialog.tscn, install_options_dialog.tscn and game_launch_menu.tscn), or drop it and use the native property. I verified locally that renaming it in the two scripts plus the three scenes is enough - the launch menu loads and behaves normally afterwards.


Disclaimer: this report was written by Claude (AI) and verified on my setup. Versions, log excerpts and the reproduction steps below are all from a real run on my machine.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions