v0.9.5: pre-launch security audit + hardening#6
Merged
Conversation
Pre-launch audit fixes (no high/critical found): - OAuth scope read:user public_repo -> read:user. public_repo grants write to public repos despite its name; reading public data needs no repo scope. Shrinks a leaked stored token's blast radius. New logins only. - Add HTTP security headers in next.config.ts: X-Frame-Options, nosniff, Referrer-Policy, Permissions-Policy (enforced) + report-only CSP baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full pre-launch security audit of the whole app — no high or critical findings. Verified sound: ownership checks on every mutation (no IDOR), AES-GCM session-token encryption, OAuth
stateCSRF (constant-time), no SQL injection, no XSS (escaped LLM narrative), no SSRF (server-side username validation), server-only secrets.Two Medium hardening fixes shipped:
read:user public_repo→read:user.public_repogrants write to public repos; reading public data needs no repo scope. Shrinks a leaked token's blast radius. New logins only; existing sessions unaffected.next.config.ts): enforcedX-Frame-Options,X-Content-Type-Options,Referrer-Policy,Permissions-Policy; plus a report-only CSP baseline (tune before enforcing).Load test split to v0.9.6; legal docs to v0.9.7.
Operator follow-ups (config, no code)
COOKIE_SECURE=truein prod.CORS_ALLOW_ORIGIN_REGEXis scoped to our origins (not*.vercel.app).Test plan
ruffclean;pytest284 passed / 69 skipped (+1 OAuth scope test)lint+tscclean; vitest 54 passed;next buildclean (headers config valid)curl -Iprod confirms security headers present;/health= 0.9.5