Repository navigation
feat: warn before a certificate expires - #1
Merged
Merged
Conversation
An uptime check notices nothing when renewal stalls. The old certificate stays valid until the hour it expires, so the monitor is green right up to the point where it is an outage. SSL_EXPIRATION sets the ssl_expiration field on every monitor the operator manages. Unset means unmanaged: the field is then left as it was, the same rule as the maintenance window. Values are checked at startup against the list Better Stack accepts, so a typo does not first surface as a rejected create call. The README also records what this does not cover: hostnames without a monitor, and that it warns about the consequence rather than the cause. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JoeyHoutenbos
force-pushed
the
feat/ssl-expiration-warning
branch
from
September 15, 2026 19:21
c9e8e33 to
fdeb120
Compare
JoeyHoutenbos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An uptime check says nothing about a certificate that stopped renewing. It keeps serving the old one, valid, right up to the hour it expires — so the monitor stays green and the first signal is the outage itself.
Every monitor this operator creates has
Verify SSL: Yes, but that only fires once the certificate is already invalid.ssl_expirationis the warning that arrives while there is still time to act, and nothing was setting it.What this adds
SSL_EXPIRATION, the number of days before expiry that Better Stack warns on.It follows the maintenance window in every respect:
1, 2, 3, 7, 14, 30, 60).10looks reasonable and is not on it; better to hear that at startup than from a rejected create call.8 tests added, 76 green.
deploy/operator.yamlsets it to 14 as an example.What it does not cover
Recorded in the README too, because it is half the story:
EXCLUDE_SUFFIXESleaves some out by design.Issuingcondition that has been true for hours — fires earlier and covers more.🤖 Generated with Claude Code