Repository navigation
Fix regressions from #772, #778 and #780 before 1.5.4 - #793
Merged
Merged
Conversation
- A workflow saved earlier with two active nodes sharing an output variable loads, triggers and runs again. The last node keeps the alias, as before; saving and importing still reject new duplicates. Annotation nodes no longer count as alias owners (#789). - Renaming an alias also rewrites templates inside literal condition operands, since the engine resolves them (#789). - The portOpen lint accepts a templated or quoted port, as the engine does (#790). - scheduledTask registers a managed service account with -LogonType Password. With ServiceAccount the task was registered but never ran; checked on a lab host (#790). - A first test-suite install creates the webhook workflow before it judges prerequisites, so both webhook workflows are enabled, and the release check verifies the integration profile it installs (#776). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three regressions that came in with #772, #778 and #780 and are not released yet.
Duplicate output variables (#789)
#778 made the alias map throw on two active nodes with the same
outputVariable. Before that, duplicating or pasting copied the alias as is, and only the linter flagged it, so installations can have such workflows stored. After the upgrade they would no longer parse: their schedule, file, database and event-log triggers would silently stop and every run would fail.The alias map now tolerates a stored duplicate and lets the last node keep the alias, which is what the engine did when the workflow was saved. Save, publish and import still reject new duplicates with
dup-output-variable, and the designer flags the pair, so it gets fixed on the next save. Annotation nodes are skipped, as in the validator. There is no data migration, the same approach ADR 0013 took for direct fan-in.Renaming an alias also rewrites
{{alias.…}}inside literal condition operands again. The engine resolves templates there, so leaving them behind silently picked the wrong branch.waitForCondition and scheduledTask (#790)
portOpenlint accepted only a JSON number. It now also takes a template or a numeric string, like the engine, so"port": "{{disc.param.selfPort}}"in the test suite no longer blocks the pre-publish checklist.scheduledTaskregistered a managed service account with-LogonType ServiceAccount. On a lab host with a gMSA, that registers fine but the task never runs (0x41303). With-LogonType Passwordit runs as the gMSA (whoami=corp\q-sdvorch2$). Built-in accounts keepServiceAccount.Test-suite release check (#776)
NP_TESTSUITE_WEBHOOK_URLtherefore exists in time, and both webhook workflows are installed enabled.-Profiles continuous, integrationthe install uses.Tests run
tsc --noEmitand ESLint on the touched files cleanscripts/test-suite/Test-TestSuiteSafety.ps1(89 assertions) andTest-WorkflowCatalogue.ps1passedCloses #789
Closes #790
Closes #776
🤖 Generated with Claude Code