Repository navigation
fix: clear previous results before record lookups - #147
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get()can returnFalsewhile leaving fields from an initialized or previously retrieved record accessible. The field/value lookup also appends to the previous result set. This lets callers continue reading stale data after a lookup misses.Clear the result buffer, cursor, count, pagination and new-record state before each lookup in both clients. Query criteria and other request settings stay intact. After a miss, value access follows the existing empty-record behavior (
NoRecordException) rather than returning the previous record's values.Fixes #59.
Validation:
python -m pytest test/test_snc_get_state.py test/test_snc_element.py -q: 27 passed on Windows/Python 3.9.25 (pytest 7.4.4) and 3.12.6. Ten new cases cover initialized/retrieved records, empty field lookups, replacement results, and recovery after a miss in both clients. Six cases fail against the unchanged implementation.python -m mypy: no issues in 14 source files.git diff --check: passed.The lookup tests mock the Table API boundary. I did not run the tenant-dependent integration suite or test against a live ServiceNow instance. Prepared and validated with Codex assistance.