Repository navigation
Move the client build to Node 26 - #328
Merged
Merged
Conversation
Node 26 becomes Active LTS on 2026-10-28. Node 24 entered maintenance on 2026-10-20 and is supported until 2028-04-30, so this is not urgent, but the window is open and 24 now receives security fixes only. The move skips 25 rather than passing through it. Odd-numbered majors never become LTS: 25 was Current from 2025-10-15 and reached end of life on 2026-06-01, which is why #323 was closed rather than fixed - it proposed a tag newer than the pinned one with a support window four months shorter. Six references move together because check-toolchains.sh requires it: the FROM in the Dockerfile with its digest, NODE_VERSION in release.yml, test.yml, security-scan.yml and tend-dependency-branches.yml, and the Dockerfile comment that used the pinned image as its own example. The digest is the OCI image index covering linux/amd64 and linux/arm64/v8, as the previous pin was, and it resolves to v26.12.1. One measured result belongs on the record, because it does not match what this project has written down twice. check-toolchains.sh and the Dockerfile both say a bundler on two different Node majors emits two different sets of content-hashed filenames. Building the client in node:24-alpine and node:26-alpine with one SENDAN_COMMIT produced 33 files whose names and bytes were identical - sha256 over the whole tree, not a spot check. The Dockerfile's own web stage, built with the same COMMIT, produced the same 33 files again. So on this toolchain the Node major is not currently a source of divergence, and the v0.2.0 failure is fully explained by the other cause the configuration records: the version name was Date.now(), so two builds disagreed by construction, which 2e038e1 fixed by naming the build after the commit. The gate is not loosened on the strength of one measurement. It costs nothing, it would catch a future bundler that does diverge, and an equality that holds today is not a guarantee. #327 carries the correction to the two comments that overstate it. Verified: check-toolchains.sh, check-workflows.py, the client builds in the pinned image, and `docker build --target web` succeeds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Serraniel <mail@serraniel.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #325. Replaces #323, which proposed Node 25 — a line that has never been
LTS and reached end of life on 2026-06-01.
Node 24 entered maintenance on 2026-10-20, so it receives security fixes only.
Nothing is urgent — it is supported until 2028 — but the window is open, and 26
is the line that will carry the next three years.
Six references, because the gate requires it
scripts/check-toolchains.shfails the build if any one of these disagrees:FROMin theDockerfile, tag and digest togetherNODE_VERSIONinrelease.yml,test.yml,security-scan.ymlandtend-dependency-branches.ymlDockerfilecomment that uses the pinned image as its own exampleThe digest is the OCI image index covering
linux/amd64andlinux/arm64/v8,the same form as the pin it replaces, and it resolves to v26.12.1.
A measurement that contradicts this project's own comment
#325 asked for the content-hashed filenames to be compared between the two build
paths, because that equality is the entire point of pinning the major. I did
that, and the result is not what
check-toolchains.shand theDockerfilebothclaim.
Built from one tree in
node:24-alpine(v24.22.1) andnode:26-alpine(v26.12.1), with
SENDAN_COMMITfixed so the version name was not a variable,then
sha256sumover all ofinternal/webui/distrather than a spot check:The
Dockerfile's ownwebstage, built with the sameCOMMIT, produced thesame 33 files a third time.
So on this toolchain the Node major is not currently a source of divergence,
and the v0.2.0 failure is fully explained by the other cause already recorded in
vite.config.ts: the version name wasDate.now(), so two builds of one sourcedisagreed by construction.
2e038e1fixed that by naming the build after thecommit. The Node major looks like a second hypothesis that was never separated
from the first.
nothing, it would catch a future bundler that does key its output to the
runtime, and an equality that holds today on one commit is not a guarantee.
What is wrong is the wording — two comments and a
CONTRIBUTING.mdparagraphstate it as established fact. #327 carries that correction, and notes that the
comparison is worth re-running when Vite or Rolldown takes a major, since that
is where the assumption could quietly become true again.
On the timing
The rule in
CONTRIBUTING.md, which #326 wrote down, is that the line must beLTS on the day it is adopted. Node 26 reaches that on 2026-10-28, seven days
out, so merging before then is seven days on a Current line.
That is your call and the PR is ready either way. My only suggestion is to
release #322 (0.3.3) first, so that release is built on a line that is LTS
today, and merge this after.
Verified
check-toolchains.sh·check-workflows.py· the client builds in the pinnedimage ·
docker build --target websucceeds · output byte-identical to theNode 24 build and to the direct build.
🤖 Generated with Claude Code