Skip to content

Refactor calculateRotationToFace function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KanadeBlue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor calculateRotationToFace function #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 22 additions & 15 deletions packages/core/src/commands/operator/summon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,18 +156,25 @@ export default register;
/**
* Calculates the rotation to face a target
*/
function calculateRotationToFace(from: Vector3f, to: Vector3f): Rotation {
const dx = to.x - from.x;
const dy = to.y - from.y;
const dz = to.z - from.z;

// Calculate the horizontal distance
const horizontalDist = Math.sqrt(dx * dx + dz * dz);

// Calculate the yaw and pitch
const yaw = (Math.atan2(-dx, dz) * (180 / Math.PI)) % 360;
const pitch = Math.atan2(-dy, horizontalDist) * (180 / Math.PI);

// Return the rotation
return new Rotation(yaw, pitch, yaw);
}
const calculateRotationToFace = (() => {
// stop RAD_TO_DEG recalling it self every time it called.
const RAD_TO_DEG = 180 / Math.PI;

return function (from: Vector3f, to: Vector3f): Rotation {
const dx = to.x - from.x;
const dy = to.y - from.y;
const dz = to.z - from.z;
// handle better.
const horizontal = Math.hypot(dx, dz);
// old code kinda goofy 270 and -90 give diffrent anwsers for same question in simple.
//old code did this 270 % 360 = 270; even tho mathmaticly i should just be -90.
let yaw = Math.atan2(-dx, dz) * RAD_TO_DEG;
if (yaw > 180) yaw -= 360;
if (yaw < -180) yaw += 360;

let pitch = Math.atan2(-dy, horizontal) * RAD_TO_DEG;
pitch = Math.max(-90, Math.min(90, pitch));

return new Rotation(yaw, pitch, yaw);
};
})();