Skip to content

Conversation

@Mqxx
Copy link
Member

@Mqxx Mqxx commented Jan 21, 2026

  • Refactored the build and publish pipeline
  • Changed JSR package structure

@Mqxx Mqxx marked this pull request as draft January 22, 2026 07:31
@Mqxx Mqxx requested a review from Katze719 January 22, 2026 08:24
@Mqxx Mqxx self-assigned this Jan 22, 2026
@Mqxx Mqxx marked this pull request as ready for review January 22, 2026 08:30
@Mqxx Mqxx marked this pull request as draft January 22, 2026 09:07
@Mqxx Mqxx marked this pull request as ready for review January 22, 2026 09:45
"${CMAKE_SOURCE_DIR}/jsr/package/jsr.json.in"
"${CMAKE_SOURCE_DIR}/jsr/package/jsr.json"
@ONLY
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wird die jsr.json nicht mehr gebraucht?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. That's what the version.txt gets generated for. The JSR.json.in still exists in the repository and get's replaced during the publishing.

Copy link
Member

@Katze719 Katze719 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a script or readme on how to publish something (locally)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. 👍🏻

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the entire publishing is done using the CI. I am not sure if a "guide on how to publish locally" will be useful? Is there a specific reason why we should allow publishing an package locally? I we allow publishing packages locally, then I would need to rewrite some of the publishing steps to be sh files (that's not the problem, question is if it is even reasonable...?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not, there is a option --dry-run, so why not let devs test locally before they push to upstream?

Copy link
Member

@Katze719 Katze719 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing in CI is a pain, and people cant push anyways without a token on local setups, but let them at least test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I will refactor it so that you are able to publish dry locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants