-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Build and Publish refactor #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Mqxx
commented
Jan 21, 2026
- Refactored the build and publish pipeline
- Changed JSR package structure
| "${CMAKE_SOURCE_DIR}/jsr/package/jsr.json.in" | ||
| "${CMAKE_SOURCE_DIR}/jsr/package/jsr.json" | ||
| @ONLY | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wird die jsr.json nicht mehr gebraucht?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. That's what the version.txt gets generated for. The JSR.json.in still exists in the repository and get's replaced during the publishing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a script or readme on how to publish something (locally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do. 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the entire publishing is done using the CI. I am not sure if a "guide on how to publish locally" will be useful? Is there a specific reason why we should allow publishing an package locally? I we allow publishing packages locally, then I would need to rewrite some of the publishing steps to be sh files (that's not the problem, question is if it is even reasonable...?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not, there is a option --dry-run, so why not let devs test locally before they push to upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing in CI is a pain, and people cant push anyways without a token on local setups, but let them at least test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I will refactor it so that you are able to publish dry locally