Skip to content

chore: drop VPS identifier from deploy script#62

Merged
satyakwok merged 2 commits into
mainfrom
chore/scrub-vps-id
May 13, 2026
Merged

chore: drop VPS identifier from deploy script#62
satyakwok merged 2 commits into
mainfrom
chore/scrub-vps-id

Conversation

@satyakwok
Copy link
Copy Markdown
Member

@satyakwok satyakwok commented May 13, 2026

Five places named the operator's mainnet host alias 'vps6'. The script header, the env doc comment, and the MAINNET_HOST default are all reworded to use 'the mainnet host' generically.

MAINNET_HOST default removed — operators must now set it explicitly (error if unset). Anyone running this script already had to point at their own ssh alias; the previous default was leak surface for one specific operator's local config.

Found by a follow-up audit pass for vps[1-9] patterns across public repos.

Summary by CodeRabbit

  • Chores
    • Updated deployment process documentation and added stricter environment validation to improve deployment reliability.

Review Change Stack

satyakwok added 2 commits May 13, 2026 09:52
'founder-private artifacts' -> 'internal artifacts' in the deploy
script's ship-list comment. Removes a name that referenced an
unpublished directory.
Five places named the operator's mainnet host alias 'vps6'. The script
header, the env doc comment, and the MAINNET_HOST default are all
reworded to use 'the mainnet host' generically.

MAINNET_HOST default removed — operators must now set it explicitly
(error if unset). Anyone running this script already had to point at
their own ssh alias; the previous default was leak surface for one
specific operator's local config.
@satyakwok satyakwok enabled auto-merge (squash) May 13, 2026 08:03
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5f90b06c-d90e-4f10-bcbb-07db0500477a

📥 Commits

Reviewing files that changed from the base of the PR and between afed5e2 and 49370f2.

📒 Files selected for processing (1)
  • scripts/deploy-mainnet.sh

📝 Walkthrough

Walkthrough

The PR updates scripts/deploy-mainnet.sh to make MAINNET_HOST a required environment variable. The header comments now document the mainnet-host workflow where source files are pushed via scp into ~/indexer-deploy, with MAINNET_HOST required rather than defaulting to vps6. The HOST initialization is changed from a default fallback to a fail-fast pattern that aborts if the variable is unset. Related comments describing scp restrictions are also refined to specifically mention avoiding internal artifacts and local node_modules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Sentriscloud/indexer#61: Both PRs modify scripts/deploy-mainnet.sh to clarify scp-based deployment scope and artifact handling warnings.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: drop VPS identifier from deploy script' clearly summarizes the main change—removing a specific VPS identifier from the deployment script.
Description check ✅ Passed The description provides clear context about what changed (removing 'vps6' references, making MAINNET_HOST required) and why (security/audit finding), though it does not follow the template structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/scrub-vps-id

Comment @coderabbitai help to get the list of available commands and usage tips.

@satyakwok satyakwok merged commit 3248229 into main May 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant