Denominator for "proportionalPol" sentiment computation#27
Open
odelmarcelle wants to merge 1 commit intoSentometricsResearch:masterfrom
Open
Denominator for "proportionalPol" sentiment computation#27odelmarcelle wants to merge 1 commit intoSentometricsResearch:masterfrom
odelmarcelle wants to merge 1 commit intoSentometricsResearch:masterfrom
Conversation
Collaborator
|
I think it's better to add a new weighting option than to change one which has been around for many versions and is implemented correctly. In the end it's just a choice and a matter of preference. I would thus add a new weighting scheme, for instance called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It always tickles me that compute_sentiment can yield values outside the [-1;1] range when using the "proportionalPol" method.
Created on 2021-12-03 by the reprex package (v2.0.0)
With this change, I adjusted the denominator so that it takes into account sentiment words that have been amplified-deamplified. Thus, the sentiment will always lie down within the [-1;1] interval.
The same example after the change:
Created on 2021-12-03 by the reprex package (v2.0.0)