Scary cleaning V2#24
Open
odelmarcelle wants to merge 431 commits intoSentometricsResearch:cleanedfrom
Open
Conversation
Former-commit-id: 4c37fa8
Former-commit-id: 35d10d2
Former-commit-id: 6d690e6
Former-commit-id: 168f589
Former-commit-id: a68a5bb
Former-commit-id: dc42ae4
Former-commit-id: 81d9048
Former-commit-id: 7c933f9
Former-commit-id: 5e029a8
Former-commit-id: 3f0fe24
Former-commit-id: 7954935
Former-commit-id: 8d04d0d
Former-commit-id: 698ee41
Former-commit-id: 412b3b4
Former-commit-id: c5dc392
Former-commit-id: 9b85ac8
Former-commit-id: 7acca8d
Former-commit-id: cee91a4
Former-commit-id: 24594ee
Former-commit-id: 4216462
Former-commit-id: b5ca11c
Former-commit-id: 58476ff
Former-commit-id: 5fa2325
Former-commit-id: 14d73a6
Former-commit-id: c54bb03
Former-commit-id: 527a677
Former-commit-id: e03fda8
Former-commit-id: 6645321
Former-commit-id: 88ba057
Former-commit-id: 2ca4657
Former-commit-id: bcfbfeb
Update of isa vignette Former-commit-id: 925b5d7
Former-commit-id: 8f4ad6d
Former-commit-id: 6839f76
Former-commit-id: 1964c21
Former-commit-id: e809daa
Former-commit-id: e32d82d
Former-commit-id: 7e1070a
Former-commit-id: 20a6eef
Former-commit-id: 77f6ff7
Former-commit-id: abd4bbd
Former-commit-id: d9b8495
Former-commit-id: 80848f7
Former-commit-id: 3d19698
Former-commit-id: 4886b86
Former-commit-id: a90680e
Former-commit-id: c9485a8
Former-commit-id: a84b124
- texts() is replaced by as.character() Former-commit-id: 00df984
Former-commit-id: f09092c
Change usage to avoid warnings for quanteda v3 Former-commit-id: 73b067b
Collaborator
|
That looks indeed very scary! Can you push it as a separate branch? Then I can investigate better if there are unintended consequences, before we merge it into master. |
Collaborator
|
Let me put it on hold for a while. Will for sure come back to this (probably after official publication in JSS), because it is a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The result of a cleaning with BFG repo cleaner.
The cleaning correct a large number of commits in the past.