feat: add gradient labels and line labels to GPU comparison charts#137
Open
functionstackx wants to merge 1 commit intomasterfrom
Open
feat: add gradient labels and line labels to GPU comparison charts#137functionstackx wants to merge 1 commit intomasterfrom
functionstackx wants to merge 1 commit intomasterfrom
Conversation
Extends the gradient label feature (parallelism strategy coloring on roofline paths) and line labels (hardware name pills) from ScatterGraph to GPUGraph, so date-range comparison charts get the same visual tools. Key changes: - Convert GPUGraph roofline layer from declarative to custom D3 rendering - Add gradient stops, parallelism pill labels, and line labels with collision avoidance - Add Gradient Labels, Line Labels toggle switches to the legend sidebar - Wire up gradient nudge toast for the comparison chart - Color scatter points by parallelism strategy when gradient labels are on - Handle zoom updates for all label types
functionstackx
force-pushed
the
feat/gpu-graph-gradient-labels
branch
from
09da1b4 to
5802015
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@adibarra can u read the code & can i get an rfr for this |
Contributor
|
The gradient line colors seem to be overwritten by the colors for the series that are being rendered when they are on in gpu comparison mode. Interestingly it seems to not happen for every combination however |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{ type: 'roofline' }to a custom D3 layer with gradient SVG defs, parallelism pill labels, and line labels with greedy collision avoidanceTest plan
🤖 Generated with Claude Code