feat: 🎸 Add prop for SQForm questions to support rich text#888
Open
Mudassar-Raza wants to merge 3 commits intoepic/style-updatesfrom
Open
feat: 🎸 Add prop for SQForm questions to support rich text#888Mudassar-Raza wants to merge 3 commits intoepic/style-updatesfrom
Mudassar-Raza wants to merge 3 commits intoepic/style-updatesfrom
Conversation
Added support for bulleted list for dropdown questions that were converting to plain text before BREAKING CHANGE: 🧨 No
Mudassar-Raza
requested review from
20BBrown14,
hvilander and
laurelbean
as code owners
Added some spacing between label text and field BREAKING CHANGE: 🧨 No ✅ Closes: #887
laurelbean
reviewed
Jul 10, 2023
stories/SQFormDropdown.stories.tsx
Outdated
|
|
||
| const defaultArgs = { | ||
| label: 'State', | ||
| label: 'Is there anything else you would like your plan to do for you?', |
Contributor
There was a problem hiding this comment.
I think changing the default label broke most of the tests for the dropdown component. Can you revert this change and make a second example story with the questions instead?
Contributor
Author
There was a problem hiding this comment.
@laurelbean I have made the suggested changes and the checks are also passed
Created a separate story for the dropdown that has questions BREAKING CHANGE: 🧨 No ✅ Closes: #887
laurelbean
approved these changes
Jul 11, 2023
laurelbean
force-pushed
the
epic/style-updates
branch
from
2e4882e to
f00b445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for bulleted list for dropdown questions that were converting to plain text before
BREAKING CHANGE: 🧨 No
Description
Currently SQForm does not support bulleted lists, rather converts questions to plain text.
We need the ability to structure form fields in a way that will allow designers to meet business requirements.
Use case:
We are unable to implement requirements due to SQFormDropdown limitations that would not allow indenting or using bullets in a single form question:
The result is that SQ from converted this into multi-line structure with no ability to format:
Figma Design file:
SC3 DESIGN LIBRARY