feat: 🎸 Add prop for SQForm fields to allow 'validation' as inf#884
Open
malikfarhan183 wants to merge 3 commits intoepic/style-updatesfrom
Open
Conversation
✅ Closes: SSR-14
✅ Closes: SSR-14
aharpt
reviewed
May 1, 2023
aharpt
reviewed
May 1, 2023
aharpt
approved these changes
May 1, 2023
✅ Closes: SSR-14
Contributor
|
Looks good. Thanks @malikfarhan183! |
laurelbean
approved these changes
Jul 10, 2023
hvilander
approved these changes
Jul 10, 2023
hvilander
reviewed
Jul 10, 2023
| }, | ||
| '&.Mui-focused': { | ||
| color: 'var(--color-textInfoBlue)', | ||
| }, |
Contributor
There was a problem hiding this comment.
why does the text field need the orange color added to error and dropdown does not?
20BBrown14
approved these changes
Jul 11, 2023
laurelbean
force-pushed
the
epic/style-updates
branch
from
2e4882e to
f00b445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Description:
We need to implement design and business requirements that require informational text to a SQForm field, similar to Validation.
Any place there is validation we need the ability for informational text, including to SQFormMultiselect, since there is currently no mechanism to override what the form engine is doing for validation text generation.
This is needed for the following input types:
Figma Fields examples: SC3 DESIGN LIBRARY
Loom Video: https://www.loom.com/share/1f883c4f27e342099f40eefab4fbb130
Other Notes : I have added the “informationalText” prop for both SQFormDropdown and SQFormTextField. Now if we will send this prop to these fields we will get the helper text under the field. let me know if we need to update the component.
Design Review : Approved by UI/UX
✅ Closes: SSR-14