Repository navigation
Fix item asset rendering across origins - #28
Merged
Merged
Conversation
swapnadeepmohapatra
marked this pull request as ready for review
July 15, 2026 12:35
shobhit-seg
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/item-assets/*URLs against the configured API origin before renderingRoot cause
The API returns portable relative asset URLs, but the production frontend and API use separate origins. Without a host rewrite, browsers requested those paths from the frontend origin and received a missing or non-image response.
Impact
Imported and uploaded images now render from
VITE_API_ORIGINwithout requiring an Amplify rewrite rule.Validation
pnpm --filter @notdrive/web typecheckpnpm --filter @notdrive/web test(no test files present)pnpm --filter @notdrive/web build