Skip to content

Use bundled CA for ClickHouse connections - #78

Merged
shobhit-seg merged 2 commits into
mainfrom
codex/use-bundled-clickhouse-ca
Jul 30, 2026
Merged

shobhit-seg merged 2 commits into
mainfrom
codex/use-bundled-clickhouse-ca

Conversation

@shobhit-seg

@shobhit-seg shobhit-seg commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • make every ClickHouse client explicitly use the Certifi CA bundle
  • keep TLS certificate verification enabled in frozen macOS builds
  • cover main, credential-test, and per-tab client creation paths
  • smoke test a real ClickHouse connection from the packaged macOS executable before publishing a release

Root cause

The packaged app includes Certifi, but Clicky did not pass ca_cert to clickhouse-connect. The frozen OpenSSL runtime therefore looked for a build-machine CA path that is absent on user machines.

Release guard

The release workflow launches dist/clicky.app/Contents/MacOS/clicky --release-connection-test and connects through the production DatabaseManager to the public, read-only ClickHouse Playground. The check uses the packaged TLS stack, needs no secrets, retries transient failures, and runs before ZIP packaging or upload.

Validation

  • 124 tests passed
  • Ruff check and format passed
  • compileall passed
  • uv lock check passed
  • release-style PyInstaller macOS build passed
  • frozen executable connected successfully to the ClickHouse Playground
  • bundled Certifi CA hash matches the source environment
  • codesign deep verification passed

@shobhit-seg
shobhit-seg requested a review from abhi204 July 30, 2026 09:54
@shobhit-seg
shobhit-seg added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit 8173923 Jul 30, 2026
1 check passed
@shobhit-seg
shobhit-seg deleted the codex/use-bundled-clickhouse-ca branch July 30, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants