Skip to content

Improve query and UI performance #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shobhit-seg merged 1 commit into from
Jul 25, 2026
Merged

Improve query and UI performance #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ def _handle_connect_success(self):
self.credentials_ui.save_credentials_callback(None, None)

# Automatically list tables after successful connection
self.table_browser_ui.invalidate_table_cache()
current_search = UIHelpers.safe_get_value("table_search", "")
self.table_browser_ui.filter_tables_callback(None, current_search)

Expand Down Expand Up @@ -154,10 +155,13 @@ def run(self):
# threads can safely update the UI without thread-safety issues.
while is_dearpygui_running():
self.async_worker.process_pending()
self.table_browser_ui.process_pending_filter()
self.ui_layout.splitter.update()
self.tabbed_query_interface.update_resize()
self.tabbed_query_interface.poll_closed_tabs()
self.tabbed_explorer.poll_closed_tabs()
render_dearpygui_frame()

self.connection_pool.close_all()
self.db_manager.disconnect()
destroy_context()
120 changes: 34 additions & 86 deletions components/query_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from config import DEFAULT_TAB_LABEL, MAX_QUERY_TABS, QUERY_INPUT_HEIGHT
from database import ConnectionPool, DatabaseManager
from icon_manager import icon_manager
from utils import get_result_column_types

MIN_QUERY_INPUT_HEIGHT = 80
MAX_QUERY_INPUT_HEIGHT = 600
Expand All @@ -33,7 +34,6 @@ class QueryTabState:
tab_tag: str
input_tag: str
run_btn_tag: str
format_btn_tag: str
save_btn_tag: str
resizer_tag: str
results_window_tag: str
Expand Down Expand Up @@ -64,7 +64,7 @@ def __init__(
async_worker=None,
):
self.connection_pool = connection_pool
self.db_manager = db_manager # used only for get_table_columns() (metadata)
self.db_manager = db_manager
self.theme_manager = theme_manager
self.async_worker = async_worker
self.status_callback: Callable[[str, bool], None] | None = None
Expand All @@ -75,6 +75,7 @@ def __init__(
self._resize_start_y: float = 0
self._resize_start_height: int = 0
self._resize_handlers_ready = False
self._themed_resizer_tab_id: int | None = None
self.table_theme = None
self._setup_table_theme()

Expand Down Expand Up @@ -120,25 +121,34 @@ def update_resize(self):
if not self._resize_handlers_ready:
self._setup_resize_handlers()

# Highlight resizer while actively dragging
if self.theme_manager:
for state in self._tabs.values():
if not does_item_exist(state.resizer_tag):
continue
is_active = self._resizing_tab_id == state.tab_id
bind_item_theme(
state.resizer_tag,
self.theme_manager.get_theme(
"resizer_active" if is_active else "resizer"
),
)
if (
self._resizing_tab_id is not None
and self._resizing_tab_id not in self._tabs
):
self._resizing_tab_id = None

# Theme bindings are DearPyGUI commands. Only send them when drag state
# changes instead of rebinding every tab on every rendered frame.
if self.theme_manager and self._themed_resizer_tab_id != self._resizing_tab_id:
for tab_id in {
self._themed_resizer_tab_id,
self._resizing_tab_id,
} - {None}:
state = self._tabs.get(tab_id)
if state and does_item_exist(state.resizer_tag):
bind_item_theme(
state.resizer_tag,
self.theme_manager.get_theme(
"resizer_active"
if tab_id == self._resizing_tab_id
else "resizer"
),
)
self._themed_resizer_tab_id = self._resizing_tab_id

if self._resizing_tab_id is None:
return
state = self._tabs.get(self._resizing_tab_id)
if state is None:
self._resizing_tab_id = None
return
_, my = get_mouse_pos(local=False)
delta = my - self._resize_start_y
new_height = int(self._resize_start_height + delta)
Expand Down Expand Up @@ -173,7 +183,6 @@ def create_tab(self) -> int:
tab_tag=f"query_tab_{tab_id}",
input_tag=f"query_input_{tab_id}",
run_btn_tag=f"run_query_btn_{tab_id}",
format_btn_tag=f"format_btn_{tab_id}",
save_btn_tag=f"save_json_btn_{tab_id}",
resizer_tag=f"query_resizer_{tab_id}",
results_window_tag=f"results_window_{tab_id}",
Expand Down Expand Up @@ -228,17 +237,6 @@ def _build_tab_ui(self, state: QueryTabState):
self.theme_manager.get_theme("button_primary"),
)

add_button(
label="{ } Format",
tag=state.format_btn_tag,
callback=self._make_format_callback(state.tab_id),
)
if self.theme_manager:
bind_item_theme(
state.format_btn_tag,
self.theme_manager.get_theme("button_secondary"),
)

add_button(
label=f"{icon_manager.get('export')} Save as JSON",
tag=state.save_btn_tag,
Expand Down Expand Up @@ -381,38 +379,12 @@ def callback(sender, data):

return callback

def _make_format_callback(self, tab_id: int):
def callback(sender, data):
self._format_query_for_tab(tab_id)

return callback

def _make_save_callback(self, tab_id: int):
def callback(sender, data):
self._save_as_json_for_tab(tab_id)

return callback

def _format_query_for_tab(self, tab_id: int):
state = self._tabs.get(tab_id)
if state is None:
return
query = get_value(state.input_tag).strip()
if not query:
if self.status_callback:
self.status_callback("Query is empty", True)
return
formatted = sqlparse.format(
query,
reindent=True,
keyword_case="upper",
indent_width=2,
wrap_after=80,
)
set_value(state.input_tag, formatted)
if self.status_callback:
self.status_callback("Query formatted", False)

def poll_closed_tabs(self):
"""Called each frame to detect tabs closed via the DPG X button."""
closed_ids = [
Expand Down Expand Up @@ -489,10 +461,9 @@ def _run_query_for_tab(self, tab_id: int):
self._on_query_error(tab_id, e)

def _execute_query_task(self, tab_id: int, query: str):
"""Background thread: execute query and fetch column types."""
"""Background thread: execute a query and reuse its returned metadata."""
result = self.connection_pool.execute_query(tab_id, query)
column_types = self._get_column_types_from_query(query, result.column_names)
return result, column_types
return result, get_result_column_types(result)

def _on_query_done(self, tab_id: int, payload):
"""Main-thread callback when query completes successfully."""
Expand Down Expand Up @@ -605,6 +576,7 @@ def _setup_results_table(self, state: QueryTabState, columns, column_types=None)
scrollX=True,
scrollY=True,
freeze_rows=1,
clipper=True,
height=-1,
width=-1,
resizable=True,
Expand Down Expand Up @@ -794,28 +766,6 @@ def _convert_results_to_json(self, state: QueryTabState):
# Helpers (shared with QueryInterface logic)
# ------------------------------------------------------------------

def _get_column_types_from_query(self, query, columns):
"""Fetch column types from DB metadata. Call from background thread only."""
column_types = {}
try:
query_lower = query.lower().strip()
from_match = re.search(r"\bfrom\s+([a-zA-Z_][a-zA-Z0-9_]*)", query_lower)
if from_match:
table_name = from_match.group(1)
try:
table_columns = self.db_manager.get_table_columns(table_name)
table_column_types = {
col_name: col_type for col_name, col_type in table_columns
}
for col in columns:
if col in table_column_types:
column_types[col] = table_column_types[col]
except Exception:
pass
except Exception:
pass
return column_types

@staticmethod
def _format_cell_value(val) -> str:
if val is None:
Expand All @@ -826,19 +776,17 @@ def _format_cell_value(val) -> str:
except Exception:
return str(val)
elif isinstance(val, str):
try:
return val.encode("utf-8", errors="replace").decode("utf-8")
except Exception:
return str(val)
return val
return str(val)

@staticmethod
def _add_default_limit(query: str) -> str:
try:
query_clean = query.strip()
query_lower = query_clean.lower()
if not query_lower.startswith("select"):
statements = sqlparse.parse(query_clean)
if len(statements) != 1 or statements[0].get_type() != "SELECT":
return query
query_lower = query_clean.lower()
limit_patterns = [
r"\blimit\s+\d+\b",
r"\blimit\s+\d+\s+offset\s+\d+\b",
Expand Down
Loading
Loading