Skip to content

fix(ci): avoid failed tag absence probe - #17

Merged
Seddryck merged 1 commit into
mainfrom
fix/release-eligibility-exit-code
Aug 14, 2026
Merged

fix(ci): avoid failed tag absence probe#17
Seddryck merged 1 commit into
mainfrom
fix/release-eligibility-exit-code

Conversation

@Seddryck

@Seddryck Seddryck commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the failing git rev-parse tag-absence probe with git tag --list
  • preserve release eligibility behavior without leaving a non-zero native process exit code

Root cause

On an eligible release, the expected missing tag makes git rev-parse --verify --quiet return exit code 1. GitHub Actions' PowerShell wrapper propagates the last native command exit code when the step finishes, so the version step fails even after writing its outputs.

Validation

  • dotnet build Expressif.LanguageServer.sln --nologo
  • dotnet test Expressif.LanguageServer.sln --no-build --nologo
  • PowerShell probe confirms a missing tag produces release-eligible=true with exit code 0

Summary by CodeRabbit

  • Bug Fixes
    • Improved release eligibility checks to correctly identify whether a version has already been released.
    • Prevented duplicate releases when a matching version tag already exists.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e16c10d1-378d-46e9-b1af-a059d43158b6

📥 Commits

Reviewing files that changed from the base of the PR and between bc09ea2 and 5a2fa84.

📒 Files selected for processing (1)
  • .github/workflows/build.yml

📝 Walkthrough

Walkthrough

The build workflow now checks for an existing version tag with git tag --list. A release is eligible only when no matching tag exists.

Changes

Release eligibility

Layer / File(s) Summary
Version tag verification
.github/workflows/build.yml
The workflow replaces git rev-parse with git tag --list "v$version". It marks the release eligible when the matching tag list is empty.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5a2fa

This localized workflow change preserves release eligibility while preventing the missing-tag check from failing the version step; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the CI fix that replaces the failing tag absence probe.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-eligibility-exit-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Seddryck
Seddryck marked this pull request as ready for review August 14, 2026 06:09
@Seddryck
Seddryck merged commit feec34e into main Aug 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant