fix(ci): avoid failed tag absence probe - #17
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe build workflow now checks for an existing version tag with ChangesRelease eligibility
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized workflow change preserves release eligibility while preventing the missing-tag check from failing the version step; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
git rev-parsetag-absence probe withgit tag --listRoot cause
On an eligible release, the expected missing tag makes
git rev-parse --verify --quietreturn exit code 1. GitHub Actions' PowerShell wrapper propagates the last native command exit code when the step finishes, so the version step fails even after writing its outputs.Validation
dotnet build Expressif.LanguageServer.sln --nologodotnet test Expressif.LanguageServer.sln --no-build --nologorelease-eligible=truewith exit code 0Summary by CodeRabbit