Skip to content

Fix "Host" HTTP header field in httpretrieve #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kellender wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix "Host" HTTP header field in httpretrieve #183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions httpretrieve.r2py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,16 +537,18 @@ def _httpretrieve_build_request(host, port, path, querydata, postdata, \
else:
# there is no proxy; send normal http request
requeststr = methodstr + ' ' + path + resourcestr + ' HTTP/1.0\r\n'

if httpheaders is not None:
# Most servers require a 'Host' header for normal functionality
# (especially in the case of multiple domains being hosted on a
# single server).
if "Host" not in httpheaders:
requeststr += "Host: " + host + ':' + str(port) + "\r\n"

for key, val in httpheaders.items():
requeststr += key + ": " + val + '\r\n'

# Make sure there is an httpheaders dict
if httpheaders is None:
httpheaders = {}
# Most servers require a 'Host' header for normal functionality
# (especially in the case of multiple domains being hosted on a
# single server).
if "Host" not in httpheaders:
requeststr += "Host: " + host + ':' + str(port) + "\r\n"

for key, val in httpheaders.items():
requeststr += key + ": " + str(val) + '\r\n'

# Affix post-data related headers and content:
if methodstr == "POST":
Expand Down