Repository navigation
Conversation
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Standalone narrow correctness fix: prevent
RebaseAgreedHashesForGamefrom partially committing primary agreement when the named-root SQL update fails. Both statements share one SQLite transaction; no schema/protocol change.Regression
TestRebaseAgreedHashesRollsBackOnNamedRootSQLFailureinjects failure in the second statement and checks primary/named-root agreement unchanged. Stock upstream RED; locally tested transaction variant GREEN with disposable SQLite.Integration
Related to #19 and upstream topology PR #139. Does not fix combined Game/ignore update atomicity or stale full-row path writes. Draft until exact-head validation and broader integration. No real user data or deployment.