Repository navigation
perf(sessions): isolate settled Codex scan optimization - #4848
Merged
Merged
Conversation
Refs #4756 Publish the exact Codex-only source and regression blobs previously tested in PR #4815 directly against master. This removes the Git fixture draft branch from the merge prerequisite without rewriting the original history. Skip redundant name enumeration on settled historical directories. Retain native change evidence and conservative unsettled directory detection. The change is partial: durable mid-scan continuation and affected-host CPU and SQLite write-latency measurements remain outstanding.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4756 — independently reviewable Codex-only slice
Partial fix. Not
Fixes #4756. Do not close the issue or merge until required tests and review complete.Why a new issue-specific PR
PR #4815 already implements this narrow Codex directory-witness improvement, but it was retargeted onto the draft Git parity fixture #4829, leaving an unrelated, unmerged PR as a prerequisite. This successor uses current
masteratcf54e0322bf574ae32068d6330bceff4426cea3dand includes exactly the two Codex source/test blobs from #4815 at8f4d6462ed0d02bbd6843a11a8f9cdba327272ff. The two affected master blobs were verified byte-identical to #4815's original base before creating this commit. Neither existing branch nor its history was rewritten.The new commit
803521383016b55214dce59b4420e6ea600bec3awas published through an exact-old-head, non-force fast-forward. It excludes the scheduler fixture owned by merged #4821 and Git parity fixture owned by draft #4829. Do not merge the same Codex changes from both #4815 and this PR.Source change and behavioral tests
read_dir+ O(entries log entries) filename sort; unsettled directories keep a name fingerprint.Evidence and remaining acceptance
The exact two Codex code/test blobs already passed the hosted Linux tests on the #4815 path (run 42527923673); its later head workflow 42547953400 passed Linux fleet, Windows, Clippy, repository and dashboard gates. These results apply to the same two source blobs on the earlier prerequisite tree, not to this new master-based commit. Require fresh nonzero
bazel test --test_output=errors //crates/tracedecay-sessions:unit_test, applicable host/integration CI, and independent review for this exact head before merging. A Bazel workspace/runner is unavailable in the authoring environment; no local Rust test pass is claimed, and Cargo was never used.Still open: the process-retained
ReadDirposition is lost on daemon restart; the durable Codex frontier saves only whole-sweep epoch/completion. The four-hour 1.5–1.8-core import, profile writes at 125–160 ms, cross-provider restart continuation, and incident-scale write/CPU improvement are not proven resolved on master. #4793 separately owns projection-queue/recovery and source-presence batching. Keep #4756 open and this change scoped.Protected mixed #4776 and every Kev/decision-model PR stay DRAFT / NO MERGE, with no work moved through them; release #4763 read-only. No production, infrastructure, tag, secret, Kody, Copilot, or delegated agent action.