Repository navigation
test(mcp): await connected replies before closing stdin - #4845
Merged
Merged
Conversation
|
ScriptedAlchemy
marked this pull request as ready for review
November 9, 2026 23:55
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
ScriptedAlchemy
changed the base branch from
codex/live-projection-during-history
to
master
November 10, 2026 03:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MCP stdio test client now waits for each connected request to receive its response before closing stdin. The two smoke tests exercise managed skill list/view and automation artifact reads. They still close the actual transport and check process exit.
This four-line harness change was previously bundled in #4814, where the Linux fleet passed all 183 selected targets. This draft isolates it on the session publication prerequisite #4831. At
69101f64d7both native MCP stdio journeys passed in 13.78 seconds. They exercised the production stdio transport, daemon replies, and client EOF.