Repository navigation
fix(ci): preserve hosted macOS DNS during fleet setup #4838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| """Preserve the Ethernet settings changed by the Tailscale macOS action.""" | ||
|
|
||
| import json | ||
| import os | ||
| import subprocess | ||
| import sys | ||
|
|
||
|
|
||
| # networksetup returns one line per entry, or a sentence when DHCP supplies it. | ||
| SETTINGS = {"dnsservers": "DNS Servers", "searchdomains": "Search Domains"} | ||
|
|
||
|
|
||
| def read_settings(service): | ||
| settings = {} | ||
| for option, label in SETTINGS.items(): | ||
| value = subprocess.check_output( | ||
| ["networksetup", "-get" + option, service], | ||
| text=True, | ||
| env={**os.environ, "LC_ALL": "C"}, | ||
| ).strip() | ||
| if not value: | ||
| raise ValueError(f"networksetup returned no result for {option}") | ||
| automatic = f"There aren't any {label} set on {service}." | ||
| settings[option] = [] if value == automatic else value.splitlines() | ||
| return settings | ||
|
|
||
|
|
||
| def restore_settings(service, settings): | ||
| for option in SETTINGS: | ||
| subprocess.run( | ||
| ["networksetup", "-set" + option, service, *(settings[option] or ["Empty"])], | ||
| check=True, | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| if sys.argv[1:] == ["read"]: | ||
| print("settings=" + json.dumps(read_settings("Ethernet"))) | ||
| elif sys.argv[1:] == ["restore"]: | ||
| restore_settings("Ethernet", json.loads(os.environ["ETHERNET_DNS"])) | ||
| else: | ||
| sys.exit("expected read or restore") | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Resolver restoration lacks regression coverage
Changes to
restore_settingscan break automatic or explicit DNS restoration without failing a checked-in test. The new reader and writer have no committed tests.Learn more
This shared CI action reads macOS resolver settings before Tailscale enrollment and restores them afterward. Both behaviors are new, but no committed test exercises the parser or the networksetup commands. The repository requires test coverage for new behavior. Local manual verification does not catch later changes to the action.
Example: Given automatic DNS and two explicit search domains, a mock
networksetupcan return the automatic DNS sentence and two domain lines. A test can check that restoration passesEmptyfor DNS and both original domains in order.Recommended fix: Add checked-in tests for
read_settingsandrestore_settingsusing mocked subprocess results. Cover automatic values, ordered explicit lists, and failed networksetup commands; run them through a maintained test target.Was this helpful? React with 👍 or 👎 to provide feedback.