Repository navigation
fix(intent): preserve admitted subagent handoff action evidence - #4836
Merged
Merged
Conversation
Refs #4540. Project an admitted assistant Task prompt into the existing observed action classifier. Keep tool-result claims and malformed argument excerpts excluded; verify negative semantic answers cannot erase genuine observed handoff activity.
|
ScriptedAlchemy
marked this pull request as ready for review
November 9, 2026 05:25
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
ScriptedAlchemy
changed the base branch from
master
to
codex/preserve-macos-runner-dns
November 9, 2026 06:30
ScriptedAlchemy
changed the base branch from
codex/preserve-macos-runner-dns
to
master
November 9, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focused observed-action repair — Refs #4540 (READY FOR REVIEW; NEVER MERGE)
Owner-requested review-state exception: PR #4836 is ready for review at the owner's explicit request. This supersedes the draft-only instruction for this PR only. Do not convert it back to draft solely because it includes decision-model work. The prohibition on merging or auto-merging remains unchanged, and readiness does not establish passing tests or complete issue acceptance.
The intent pass already separates user prompt inference from admitted assistant tool activity. However,
tool_call_factsparsed an assistant tool'ssubagent_typebut discarded itsprompt. The existingobserved_action_factsclassifier recognizes a real Task/Agent handoff only when that invocation's prompt contains handoff/context evidence. That predicate was therefore unreachable from the canonical session-window intent path even for a complete, authenticated assistant Task call.This changes the existing adapter to forward the JSON
promptfrom admitted assistant tool calls only. It does not scrape tool output, interpret the user's prompt as a recorded action, infer anything from invalid/truncated JSON, create an additional classifier/transport, or alter model thresholds, authorization, delivery, dedupe or receipts.Falsifiable regression
New
admitted_subagent_prompt_is_observed_but_forged_or_partial_calls_are_notuses the realSessionWindowV1andwindow_intent_signalsproduction path:SubagentStartContextas ActionFact, even if the configured semantic question receives a usable negative 0.1 answer.The original adapter fails the first assertion; the negative cases protect the source identity boundary. No existing assertions are removed or weakened. One source/test file changed (84 added lines).
Evidence and outstanding acceptance
AGENTS.mdand master source read. Exact basec231fb7219f8fc2f334b911ada656bdb2c6e13a4. Independently checked the one-file GitHub commit diff and verified a one-parent, expected-old-headforce=falsebranch fast-forward.Refs #4540, not complete acceptance; leave the issue open.At
362ff7f1e6the one-file handoff patch exactly matches55695a9a16. The branch now uses the hosted runner setup prerequisite. Before this change, macOS lost public DNS after enrollment, and the Linux fleet and Dashboard both stopped on the launcher HTTP 504 before testing. Hosted Linux and native macOS verification on the stacked commit.The hosted native macOS job passed. On the dependent #4836 head the runner log shows the Tailscale DNS override, restoration of Ethernet settings, a fresh download of Bazel 9.3.2 from releases.bazel.build, and 574 passing agent-hosts tests with one opt-in evaluation ignored.
Kev/decision-model merge hold: this PR must NEVER be merged or auto-merged under the current authorization. Only PR #4836's draft-only restriction has been lifted. Mixed #4776 and other decision-model PRs remain draft/never merge; beta.99 #4763 is read-only. No release, tag, production, infra, credentials, model run or external coding agents.