Repository navigation
fix(lcm): serialize summary publication per store and session - #4830
Merged
Merged
Conversation
|
This was referenced Nov 9, 2026
ScriptedAlchemy
changed the base branch from
master
to
codex/linux-launcher-distribution
November 9, 2026 06:22
ScriptedAlchemy
changed the base branch from
codex/linux-launcher-distribution
to
codex/windows-bazel-release-archive
November 9, 2026 08:27
ScriptedAlchemy
changed the base branch from
codex/windows-bazel-release-archive
to
master
November 9, 2026 09:08
ScriptedAlchemy
marked this pull request as ready for review
November 9, 2026 23:54
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The foreground hook and the retained summary worker can plan against the same session before either has published its result. Serialize planning through publication for each store, provider and session. Other sessions continue independently, and a queued caller can cancel or reach its deadline.
This isolates the compression change identified in the #4810 review. Its two-file patch comes from
548db008c2. The standalone master-based macOS Bazel run passed all 39 LCM effects tests, including cancellation of a queued caller while another session acquired its turn. The hosted workflow on #4814 previously passed with the same runtime fix.Keep this draft for independent review. The idle receipt query on #4810 and foreground scheduler changes have separate review paths.
The current verification run checks
c914e408d4against #4837 at2f533c434e. This head includes the Linux launcher download prerequisite. The 2-file feature diff has the same paths and stable patch ID after updating the prerequisite.