Skip to content

build: consume Grafeo fork main without a downstream patch - #4721

Closed
ScriptedAlchemy wants to merge 2 commits into
masterfrom
build/grafeo-fork-main
Closed

ScriptedAlchemy wants to merge 2 commits into
masterfrom
build/grafeo-fork-main

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Scope

Consume the allocation-accounting APIs maintained directly on ScriptedAlchemy/grafeo main, rather than applying them only through a downstream Bazel patch.

All five sibling Grafeo crates use branch = "main"; Cargo.lock pins 5116be3c7b9392006ef4d229634963e1306a7b6b, merged in ScriptedAlchemy/grafeo#14. The local patch and its Bazel annotation are removed. No unrelated dependency revisions change.

Shared CI fixture repair

Commit 9651a9ff7f03d69bdfd2d1a0b5dfb7c55f8bf070 applies the exact reviewed fix from #4731 after this branch's private Linux run failed three ignored-dependency admission tests at the redundant generation-publication wait. The original file matched #4731's parent byte-for-byte; the replacement blob is 9135cf4f9077156831e3f0bb0141f40b99503b65.

The fixture waits directly for its existing stronger fresh serving-generation state. Every admission assertion and the serving-readiness deadline remain unchanged. This is a non-force follow-up commit, not a merge into master.

Validation

The original implementation reported a successful bounded LCM compiler check, Grafeo allocation tests (3 with LPG/compact-store and 4 with temporal), focused formatting/Clippy, and patch-registry validation. Those results predate this follow-up and are not full current-branch runtime validation.

The original private Linux run 41606692236 passed 179/181 Bazel targets. This fixture repair addresses its code-index admission race; the separate cold-daemon Git-sync git_topology_declared_authority_unavailable failure remains unresolved.

The shared fixture fix passed native Linux on #4731 (run 41665062193). This does not establish that the updated Grafeo integration passes. Fresh exact-head CI is queued at https://github.com/ScriptedAlchemy/tracedecay/actions/runs/41706760515. No local Rust compilation or tests ran during this follow-up; complete applicable hosted Bazel validation is required before merge.


Devin Review

@changeset-bot

changeset-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9651a9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Apply the reviewed fixture repair from fbca068 (#4731) after this branch's private Linux run failed three admission tests at the redundant generation-publication wait. The original fixture blob matches exactly.

Retain the stronger fresh serving-seat wait and every admission assertion. No timeout increases, production changes, or validation skips. The independent cold-daemon Git topology failure is not addressed by this repair.

The shared repair passed native Linux on #4731; the updated Grafeo branch still needs its own full hosted Bazel validation. No local Rust execution is claimed.
@ScriptedAlchemy

Copy link
Copy Markdown
Owner Author

Consolidated into #4742 (integrate/open-pull-requests) at the captured head shown in its description, as requested. Continue review and further fixes on #4742. This closure does not assert CI readiness; the replacement remains draft. Source branch retained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant