Repository navigation
refactor(code-index): drop the activation prewarm CPU knob - #4086
Merged
Merged
Conversation
set_injected_activation_prewarm_cpu spun CPU beside the prewarm so a test could show the debug long-poll guard no longer failed the worker (#4022). With long polls counted instead of failed, the test passes whether or not the prewarm runs on a worker, so the knob and its test go. The prewarm stays on the blocking pool.
inject_registered_schema_convergence_trim_cpu_for_test spun CPU beside malloc_trim for the same guard-only test (#4027). It goes with that test. The trim stays on the blocking pool.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ScriptedAlchemy
enabled auto-merge
October 16, 2026 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two test-only CPU-injection knobs on production types go away. They existed so a test could spin a poll past the debug long-poll guard and show the guard no longer failed the task. #4076 counts long polls instead of failing them, so those tests pass whether or not the work stays on a worker and assert nothing.
Scope
tracedecay-code-index-runtime: removesset_injected_activation_prewarm_cpuandInjectedActivationFaultsV1::prewarm_cpu(fix(code-index): prewarm memory activations on the blocking pool #4022) and the testa_memory_activation_longer_than_one_native_poll_still_seats.prewarm_serving_derivationsstill runs on the blocking pool.tracedecay-store-runtime: removesinject_registered_schema_convergence_trim_cpu_for_testand thetrim_cpufield (fix(runtime): trim off the native poll and park panicked workers #4027) and the testschema_convergence_completes_when_its_allocator_trim_outlasts_a_native_poll.malloc_trimstill runs on the blocking pool, and the convergence supervisor stays.Blast Radius
Test-helper surface only. Production code paths are unchanged apart from the removed
cfg(test)andtest-helpersbranches.Verification
//crates/tracedecay-code-index-runtime:unit_test,//crates/tracedecay-store-runtime:unit_test, and//crates/tracedecay:unit_testpass.--config=clippyand rustfmt are clean for the three crates.