Repository navigation
fix: repair two runtime acceptance reds on master - #3995
Merged
Merged
Conversation
rules_rust reports a dated nightly's version as its compiler semver (1.100.0 for nightly-2026-09-27). The test launcher exported that as RUSTUP_TOOLCHAIN, which rustup reads as an uninstalled stable toolchain, so the daemon's rust-analyzer proxy was refused, no semantic route mounted, and production_lsp_negotiates_and_projects_canonical_context negotiated no documentSymbolProvider. Regressed with the nightly pin in f152080 (#3883); 1.99.0 had been a valid rustup name.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests in
//crates/tracedecay:runtime_acceptance_suitefail on master. They have different causes.production_lsp_negotiates_and_projects_canonical_contextThe Bazel test launcher exported
RUSTUP_TOOLCHAIN=toolchain.version. For the dated nightly that #3883 (f152080) pinned, rules_rust reportsversion = "1.100.0", and rustup reads that as a stable toolchain that is not installed:The daemon's broker then refused the rust-analyzer proxy, no semantic route mounted, and
initializereturned nodocumentSymbolProvider. Before the pin,1.99.0was a valid rustup name. The launcher now exports<channel>-<iso_date>(herenightly-2026-09-27) when the toolchain is dated, andversionotherwise.rust_test_environment_probealready expected anightly-value. Until now it fell through to its stable branch.current_codex_user_pair_projects_once_and_rejects_malformed_itemsThis is a stale expectation. a2a0cb1 (#3884) deliberately made a user
response_itemmessage a canonical turn beside itsitem_completedecho. It reversed the 9d1f430 dedupe and updated the transcript-ingest suites, but missed this test. The test now expects two projected user turns and still checks that the two malformed items project nothing. It is renamed tocurrent_codex_user_pair_projects_each_record_and_rejects_malformed_items.Verification
All runs used local Bazel at the PR head:
//crates/tracedecay:runtime_acceptance_suitePASSED.//scripts:rust_test_environment_probePASSED.//crates/tracedecay:rustfmt_check_2024are clean.