Repository navigation
fix(memory): resample unthrottled after allocator trim - #2856
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
devin/1790906115-rebase-2596
branch
from
October 2, 2026 02:29
225a0c9 to
a017a1e
Compare
5 of 7 tasks
Owner
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master(1bdded9). This branch was rebased ontomasterand now contains only the fix below.sample_for_checkpoint(). If an indexing checkpoint had sampled within the lastRESIDENT_MEMORY_CHECKPOINT_SAMPLE_INTERVAL_V1, the post-trim read was skipped.run_pressure_reclaimersdoes not resample afterwards, so the OverBudget latch stayed up after memory had recovered. Admissions kept returningObservedOverBudgetuntil the maintenance sampler ran again, which can take about 30s.Motivation
Raised in Devin Review on this PR. Without this fix, an allocator trim that brings cgroup usage below the low watermark can leave admission refused.
Changes
crates/tracedecay-runtime-core/src/resident_memory.rs: new privatepublish_post_reclaim_sample, called fromregister_process_allocator_pressure_reclaimer_v1.crates/tracedecay-runtime-core/src/resident_memory/tests.rs:allocator_reclaim_publishes_recovery_after_recent_checkpoint. A checkpoint arms the throttle, then a priority-0 owner reclaimer lowers the canonical reading, then the trim runs. The test asserts the state is Nominal andreservesucceeds.Test plan
cargo test -p tracedecay-runtime-core --lib resident_memory: 52 passed (after the rebase ontomaster)cargo fmt --check -p tracedecay-runtime-corecargo nextest run --workspaceis left to CIChecklist
CHANGELOG.mdupdated (not done).envfiles includedLink to Devin session: https://app.devin.ai/sessions/26e8a6e6fdd04bc3ba3661c3b6a1869b
Open in Devin Desktop: https://app.devin.ai/desktop/session/26e8a6e6fdd04bc3ba3661c3b6a1869b?variant=devin
Requested by: @ScriptedAlchemy