Repository navigation
test(code-index): assert exact scheduler and snapshot outcomes - #2614
Conversation
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f57ede8a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assert_eq!( | ||
| injected_activation_attempt_count(&scope.worktree_id), | ||
| 1, | ||
| "the fixture observes one graph activation attempt for the seated generation" | ||
| ); |
There was a problem hiding this comment.
Avoid asserting a raced activation count
On a slow or loaded test runner, the first text projection and serving swap can take longer than the test-only 50 ms activation backoff; the retry wake can then start a second activation before wait_for_seated_generation() observes the newly seated generation. The serving behavior remains correct, but the count is already 2 and this exact assertion fails nondeterministically. Synchronize observation before allowing the retry, or assert only the behavior required by this test rather than an unsynchronized attempt count.
Useful? React with 👍 / 👎.
1f57ede to
c298595
Compare
c298595 to
f9dc9c7
Compare
Summary
lexical_weight_ppm1000000 andgraph_weight_ppm250000) and shows each one moves the digest.Mutation proof
Each rewrite failed while the old weak predicate stayed true, then passed after
git checkout --restored production:NotFound { branch: "missing" }failed when the error becameReferenceUnavailable(is_errstill held).lexical_weight_ppmbefore the hash failed the lexical inequality.record_injected_activation_attemptmade the attempt count 2 (> 0andis_somestill held) and failed the literal count and seatedsrc/main.rs/mainfunction asserts.git_repository_missingfailed the literalgit_repository_unavailable(is_errstill held).ImportEmptyBindingNamefailed theImportAuthorityMismatchmatch.raw_scorefailed the left-then-right anchor order.Suites
Non-zero results on the touched crates: code-index lib 260, code_index_suite 182, resident_accounting 3, retention lib 111, runtime lib 545 (1 ignored), query lib 272 (1 ignored), canonical_execution_equivalence 5, index_bench_workload 1, retrieval_contract_spine 2, search_quality_suite 75, temporal-query lib 179, temporal hotpath_coverage 1, search-eval bins 3 and 3. Focused rewrites: 1+1+2+1+1+1 passed. Clippy
-D warningson the touched crates passed.cargo fmt --all -- --checkpassed.tracedecay-search-evallib is 35 passed and 1 failed:baseline_report_retains_raw_fallback_current_and_exact_ten_x_samplescompares query-fallback trainsha256:b25e8f6c5fa1b1da422a35b1fb1510b430797dbce898277cbf7995796c437d22to pinnedsha256:3a9ac57b8868d65a89b0475be25d49e2b6fab779fe1c55af519889b2dc7064db. The fixture is the packaged evaluator pack, and this diff does not change ranking or that pin. Not re-pinned.Skipped
memory_tests.rsis dirty in worktree/fast/tmp/fleet-graph-activation-allowance(fleet/graph-activation-allowance). Serving, registry, and reconcile files stay with PR #2452 (cursor/seal-serving-latency-669e) and PR #2596 (agent/master-unpushed-20260928). Index exclude/include files stay with PR #2514 (fleet/fix-unowned-issues-index-settings), includingtracedecay-graph-querylib.rsandverified_query_source_tests.rs.