fix(mcp-catalog): keep an unsized project count out of context help - #2323
Merged
Merged
Conversation
`tracedecay tool context --help` printed "This project (0 nodes) allows 3 broad context calls": the static tool registry embedded the dynamic call-budget sentence with placeholder figures it cannot compute. The static description now carries only the tool's purpose; live discovery keeps adding the node count and budget (or the warming variant) where a project graph sizes them.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding (f) from running the released 1.0.0-beta.55:
tracedecay tool context --helpprintedThis project (0 nodes).Cause
The static tool registry built the
tracedecay_contextdefinition withcontext_description(0, 3), the dynamic call-budget sentence filled with placeholder figures. Help renders the static registry and has no project graph to size, so it printed a node count and budget it could not compute.Change
CONTEXT_DESCRIPTIONholds the tool's purpose alone and is the static description.context_description(node_count, budget)andcontext_warming_description(budget)append their sentence to it, so livetools/listkeeps the computed figures (or the warming variant) and help no longer invents them.Test
context_help_describes_the_tool_without_a_project_size(core_cli_suite) runs the built binary with an isolated home and asserts the description line literally.… Use it for broad questions that need relationship synthesis across the code graph. This project (0 nodes) allows 3 broad context calls.… relationship synthesis across the code graph.Journey
Released beta.55 printed the same line followed by
This project (0 nodes) allows 3 broad context calls.Verification
cargo test -p tracedecay-mcp-catalog: 29 passed (includesper_session_budget_does_not_leak_through_the_cached_registry: a budgeted registry still carriesN broad context calls)cargo test -p tracedecay-cli --test core_cli_suite -- cli_boundary: 3 passedcargo test -p tracedecay --features test-helpers --lib -- bootstrap(warmingtools/listdescriptions still say3 broad context callsandgraph is still warming): 68 passedcargo clippy -p tracedecay-mcp-catalog -p tracedecay-cli --all-targets -- -D warnings, with and withouttest-transport: clean, after rebasing onto fix(domain): box project route detail so master clippy passes #2315, which fixed fix(domain): TraceDecayError too large for clippy since 21552e3764 #2308.cargo fmt --all -- --check: clean.