-
Notifications
You must be signed in to change notification settings - Fork 6
fix(domain): box project route detail so master clippy passes #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
54ef776
fix(domain): box project route detail to keep errors small
ScriptedAlchemy bfd02de
fix(query): clear restore clippy lints and stale size assertion
ScriptedAlchemy d196c18
test(daemon-service): classify owner-served dashboard and test runs
ScriptedAlchemy 46a9d4f
fix(domain): box project route detail to keep errors small
ScriptedAlchemy 10929f4
fix(query): clear restore clippy lints and stale size assertion
ScriptedAlchemy 98b1f1c
test(daemon-service): classify owner-served dashboard and test runs
ScriptedAlchemy 80dcbcd
Merge remote-tracking branch 'origin/master' into fleet/clippy-large-err
ScriptedAlchemy 5730ff6
Merge remote-tracking branch 'origin/fleet/clippy-large-err' into fle…
ScriptedAlchemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test enforces a substantially stricter constraint than the
result_large_errlint it is meant to protect: a legitimate future variant that makesTraceDecayError72–120 bytes would still satisfy Clippy but would fail the unit suite and force unnecessary boxing. Rely on the workspace Clippy check, or at least derive the assertion from the lint's actual threshold instead of freezing the enum at its incidental current size; repository guidance also explicitly rejects hard-coded gate counts as acceptance evidence.AGENTS.md reference: AGENTS.md:L172-L176
Useful? React with 👍 / 👎.