test(mcp): prove tracedecay_feedback_diagnostics behavior - #1694
Merged
Merged
Conversation
|
Call the production MCP tools/call path and assert the literal JSON-RPC refusal for rejected arguments and the concealment problem for handles the daemon never minted. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Call the production tools/call path with the handle the advisory cycle mints and assert the returned cycle matches the fixture checkout. A list handle minted for a different read stays concealed. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/prove-feedback-diagnostics-ea7f
branch
from
September 18, 2026 08:00
7766c1a to
bd33d26
Compare
A compiler warning published through the production diagnose tool is returned by tools/call for the minted handle, keyed to the fixture checkout. A sibling list handle stays concealed. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
ScriptedAlchemy
marked this pull request as ready for review
September 18, 2026 08:36
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The first cycle payload was overwritten before anything read it. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracedecay_feedback_diagnosticsthrough the production MCPtools/callpath on a mounted project.not_found_or_not_authorizedconcealment problem, not an empty cycle.rustcwarning (unused variable: unused_anchor) is the finding, the checkout HEAD is the scope, and a repeat read returns the same cycle under a new request id.Motivation
Schema pins still pass if the daemon answers with an empty success or a differently typed refusal. These tests call the tool the way a host does. The success case publishes a compiler warning through
tracedecay_diagnose, takes the diagnostics handle the advisory cycle mints, and asserts the literal diagnostics payload.Changes
crates/tracedecay/tests/mcp_suite/mcp_handler_test/feedback_diagnostics_test.rs— production MCP journeys for this tool only.Test plan
REQUIRE_EXACT_TEST_COUNT=2 scripts/require-exact-test.sh cargo test -p tracedecay --features test-transport --test mcp_suite mcp_handler_test::feedback_diagnostics_test -- --test-threads=1feedback_diagnostics_returns_the_published_cycle_for_its_minted_handle,feedback_diagnostics_refuses_bad_arguments_and_denies_unknown_handles)CI note
The four red checks on
6f1d1deare not this tool:crates/tracedecay-privacy/src/rules.rs(doc_lazy_continuation), which is unchanged onmaster.cargo fmt --all --checkinlifecycle_lease.rsandcode_index_generations/locking.rs, also unchanged onmaster.This PR does not change those crates.
Checklist
CHANGELOG.mdupdated (under[Unreleased]if no version bump).envfiles included