Skip to content

test(mcp): prove tracedecay_feedback_expand behavior - #1688

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
cursor/prove-feedback-expand-f32a
Sep 19, 2026
Merged

ScriptedAlchemy merged 1 commit into
masterfrom
cursor/prove-feedback-expand-f32a

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Proves tracedecay_feedback_expand through the production MCP server, not a schema or handler mock.
  • A published compiler diagnostic is expanded by its daemon-minted handle. The tool returns that finding and its one diagnostic anchor.
  • A missing argument, a blank handle, an unknown handle, and a diagnostics handle are refused with the typed errors a caller actually sees.

Motivation

The expand tool is handle-gated. Advertising the request schema does not show that a real handle hydrates the retained diagnostic, or that the other handles fail closed.

Changes

  • crates/tracedecay/tests/mcp_suite/mcp_handler_test/feedback_expand_test.rs calls the production tool and asserts literal payloads.

Test plan

  • scripts/require-exact-test.sh cargo test -p tracedecay --features test-transport --test mcp_suite mcp_handler_test::feedback_expand_test::feedback_expand_returns_the_published_diagnostic_and_denies_other_handles -- --exact — passed locally: ok. 1 passed; 0 failed; 350 filtered out; finished in 2.15s
  • Do not merge. This PR only owns tracedecay_feedback_expand.

Checklist

  • No secrets, credentials, or .env files included
  • No changelog: test-only, no product behavior change
  • No breaking changes
Open in Web Open in Cursor 

Call the production MCP tool with a published diagnostic handle and
assert the returned finding and anchor, plus the typed refusals for a
missing, blank, unknown, or wrong-operation handle.

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5c2ab0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy marked this pull request as ready for review September 18, 2026 08:22
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@ScriptedAlchemy
ScriptedAlchemy merged commit 6d59e9f into master Sep 19, 2026
23 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants